Skip to content

RUMM-2463 Add API to enable/disable tracking of frustration signals#1085

Merged
plousada merged 2 commits into
developfrom
plousada/RUMM-2463/public-api-frustrations-signals
Oct 14, 2022
Merged

RUMM-2463 Add API to enable/disable tracking of frustration signals#1085
plousada merged 2 commits into
developfrom
plousada/RUMM-2463/public-api-frustrations-signals

Conversation

@plousada

@plousada plousada commented Oct 13, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Adds a public API to disable/enable tracking of frustration signals.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada
plousada requested a review from a team as a code owner October 13, 2022 09:41
@xgouchet xgouchet added the size-small This PR is small sized label Oct 13, 2022
0xnm
0xnm requested changes Oct 13, 2022
View reviewed changes

@0xnm 0xnm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm! I just added few minor suggestions.

Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/core/configuration/Configuration.kt Outdated
Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScope.kt Outdated
Comment thread ...-android/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScopeTest.kt
Comment thread ...-android/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumActionScopeTest.kt
Comment thread ...oid/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumApplicationScopeTest.kt
Comment thread ...rc/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumContinuousActionScopeTest.kt
Comment thread ...android/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumSessionScopeTest.kt
Comment thread ...oid/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewManagerScopeTest.kt Outdated
Comment thread ...dk-android/src/test/kotlin/com/datadog/android/rum/internal/domain/scope/RumViewScopeTest.kt Outdated
Comment thread ...dk-android/src/test/kotlin/com/datadog/android/rum/internal/monitor/DatadogRumMonitorTest.kt Outdated
@plousada
plousada force-pushed the plousada/RUMM-2463/public-api-frustrations-signals branch 2 times, most recently from 01fb72a to 308fc9f Compare October 13, 2022 14:16
mariusc83
mariusc83 approved these changes Oct 13, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/rum/internal/domain/scope/RumSessionScope.kt
@plousada
plousada force-pushed the plousada/RUMM-2463/public-api-frustrations-signals branch from 308fc9f to e4de88d Compare October 13, 2022 15:20
@plousada
plousada force-pushed the plousada/RUMM-2463/public-api-frustrations-signals branch from e4de88d to d33034a Compare October 14, 2022 09:27
@codecov-commenter

codecov-commenter commented Oct 14, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1085 (d33034a) into develop (1d7c40c) will increase coverage by 0.05%.
The diff coverage is 91.43%.

@@             Coverage Diff             @@
##           develop    #1085      +/-   ##
===========================================
+ Coverage    83.13%   83.18%   +0.05%     
===========================================
  Files          272      272              
  Lines         9285     9310      +25     
  Branches      1494     1494              
===========================================
+ Hits          7719     7744      +25     
- Misses        1144     1149       +5     
+ Partials       422      417       -5
Impacted Files Coverage Δ
...atadog/android/core/configuration/Configuration.kt 97.46% <40.00%> (-1.24%) ⬇️
.../main/kotlin/com/datadog/android/rum/RumMonitor.kt 78.26% <100.00%> (+0.48%) ⬆️
...lin/com/datadog/android/rum/internal/RumFeature.kt 93.14% <100.00%> (+0.14%) ⬆️
...ndroid/rum/internal/domain/scope/RumActionScope.kt 98.51% <100.00%> (+0.02%) ⬆️
...d/rum/internal/domain/scope/RumApplicationScope.kt 100.00% <100.00%> (ø)
...droid/rum/internal/domain/scope/RumSessionScope.kt 91.67% <100.00%> (+0.36%) ⬆️
...d/rum/internal/domain/scope/RumViewManagerScope.kt 98.21% <100.00%> (+0.07%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 96.94% <100.00%> (+0.03%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.00% <100.00%> (+0.09%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 70.00% <0.00%> (-20.00%) ⬇️
... and 3 more

@plousada
plousada merged commit 59192b1 into develop Oct 14, 2022
@plousada
plousada deleted the plousada/RUMM-2463/public-api-frustrations-signals branch October 14, 2022 10:52
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-small This PR is small sized

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@plousada @codecov-commenter @xgouchet @mariusc83 @0xnm