Skip to content

Migrate ktlint CI job to shared gitlab template#1084

Merged
daniel-m-dd merged 2 commits into
developfrom
d.marin/ktlint
Oct 13, 2022
Merged

Migrate ktlint CI job to shared gitlab template#1084
daniel-m-dd merged 2 commits into
developfrom
d.marin/ktlint

Conversation

@daniel-m-dd

@daniel-m-dd daniel-m-dd commented Oct 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Use the Ktlint job from the shared pipeline (should be merged after the shared template update PR)

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@daniel-m-dd

daniel-m-dd commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

Don't see any changes from this PR impacting the failing jobs...

@daniel-m-dd
daniel-m-dd marked this pull request as ready for review October 13, 2022 08:03
@daniel-m-dd
daniel-m-dd requested a review from a team as a code owner October 13, 2022 08:03
@codecov-commenter

codecov-commenter commented Oct 13, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1084 (33502b2) into develop (8c0ac9c) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1084      +/-   ##
===========================================
+ Coverage    83.13%   83.21%   +0.08%     
===========================================
  Files          272      272              
  Lines         9285     9285              
  Branches      1494     1494              
===========================================
+ Hits          7719     7726       +7     
  Misses        1144     1144              
+ Partials       422      415       -7
Impacted Files Coverage Δ
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (-10.00%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 91.33% <0.00%> (-0.58%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.11% <0.00%> (+2.16%) ⬆️
...nternal/persistence/file/batch/BatchFileHandler.kt 81.13% <0.00%> (+2.83%) ⬆️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 100.00% <0.00%> (+3.85%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@daniel-m-dd
daniel-m-dd merged commit 1d7c40c into develop Oct 13, 2022
@daniel-m-dd
daniel-m-dd deleted the d.marin/ktlint branch October 13, 2022 09:16
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@daniel-m-dd @codecov-commenter @0xnm @xgouchet