Skip to content

RUMM-2600 SR accept optional Typeface when resolving fontStyle#1082

Merged
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2600/sr-npe-when-resolving-fontfamily
Oct 12, 2022
Merged

RUMM-2600 SR accept optional Typeface when resolving fontStyle#1082
mariusc83 merged 1 commit into
feature/sdkv2from
mconstantin/rumm-2600/sr-npe-when-resolving-fontfamily

Conversation

@mariusc83

@mariusc83 mariusc83 commented Oct 12, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Sometimes the TextView#typeface property is Null and this was causing NPE when trying to resolve the fontStyle for the equivalent TextWireframe.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83
mariusc83 requested a review from a team as a code owner October 12, 2022 08:59
@mariusc83 mariusc83 self-assigned this Oct 12, 2022
@codecov-commenter

codecov-commenter commented Oct 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1082 (4650702) into feature/sdkv2 (946cc7e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           feature/sdkv2    #1082      +/-   ##
=================================================
- Coverage          82.58%   82.58%   -0.01%     
=================================================
  Files                346      346              
  Lines              11157    11157              
  Branches            1831     1831              
=================================================
- Hits                9214     9213       -1     
- Misses              1381     1383       +2     
+ Partials             562      561       -1
Impacted Files Coverage Δ
...ssionreplay/recorder/mapper/TextWireframeMapper.kt 90.16% <ø> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 86.27% <0.00%> (-1.96%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 82.81% <0.00%> (ø)
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.52% <0.00%> (ø)
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.83% <0.00%> (+0.53%) ⬆️

@mariusc83
mariusc83 merged commit f127668 into feature/sdkv2 Oct 12, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2600/sr-npe-when-resolving-fontfamily branch October 12, 2022 12:00
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-tiny

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet