RUMM-2528 prevent crash on peekBody#1080
Merged
Merged
Conversation
0xnm
approved these changes
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1080 +/- ##
===========================================
+ Coverage 83.19% 83.21% +0.02%
===========================================
Files 272 272
Lines 9279 9285 +6
Branches 1494 1494
===========================================
+ Hits 7719 7726 +7
- Misses 1143 1144 +1
+ Partials 417 415 -2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent crashes from calling
peekBodyin DatadogInterceptor. Some implementations had some unchecked exceptions we missed.Motivation
Fixes #1049