Skip to content

RUMM-2528 prevent crash on peekBody#1080

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/RUMM-2528/peekBody_crash
Oct 12, 2022
Merged

RUMM-2528 prevent crash on peekBody#1080
xgouchet merged 1 commit into
developfrom
xgouchet/RUMM-2528/peekBody_crash

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

What does this PR do?

Prevent crashes from calling peekBody in DatadogInterceptor. Some implementations had some unchecked exceptions we missed.

Motivation

Fixes #1049

@xgouchet
xgouchet requested a review from a team as a code owner October 11, 2022 15:03
@codecov-commenter

codecov-commenter commented Oct 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1080 (3d1970d) into develop (7df131c) will increase coverage by 0.02%.
The diff coverage is 28.57%.

@@             Coverage Diff             @@
##           develop    #1080      +/-   ##
===========================================
+ Coverage    83.19%   83.21%   +0.02%     
===========================================
  Files          272      272              
  Lines         9279     9285       +6     
  Branches      1494     1494              
===========================================
+ Hits          7719     7726       +7     
- Misses        1143     1144       +1     
+ Partials       417      415       -2     
Impacted Files Coverage Δ
...n/kotlin/com/datadog/android/DatadogInterceptor.kt 87.06% <28.57%> (-6.61%) ⬇️
...og/android/rum/internal/anr/ANRDetectorRunnable.kt 82.76% <0.00%> (-3.45%) ⬇️
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 86.54% <0.00%> (-1.92%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.49% <0.00%> (+0.58%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.65% <0.00%> (+1.08%) ⬆️
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 100.00% <0.00%> (+3.85%) ⬆️
...id/webview/internal/rum/WebViewRumEventConsumer.kt 86.05% <0.00%> (+9.30%) ⬆️

@xgouchet
xgouchet merged commit 53dba56 into develop Oct 12, 2022
@xgouchet
xgouchet deleted the xgouchet/RUMM-2528/peekBody_crash branch October 12, 2022 07:25
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled IllegalStateException in DatadogInterceptor

3 participants