RUMM-2536: Use SDK v2 configuration interfaces for features#1079
Merged
0xnm merged 1 commit intoOct 12, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1079 +/- ##
=================================================
- Coverage 82.57% 82.56% -0.01%
=================================================
Files 347 346 -1
Lines 11202 11157 -45
Branches 1845 1831 -14
=================================================
- Hits 9249 9211 -38
- Misses 1378 1383 +5
+ Partials 575 563 -12
|
0xnm
marked this pull request as ready for review
October 11, 2022 14:27
0xnm
force-pushed
the
nogorodnikov/rumm-2536/use-v2-configuration-interface
branch
from
October 11, 2022 14:37
f710ed7 to
3b40dae
Compare
xgouchet
approved these changes
Oct 12, 2022
mariusc83
reviewed
Oct 12, 2022
| context: Context, | ||
| storage: Storage, | ||
| configuration: Configuration.Feature.CrashReport | ||
| private fun createPersistenceStrategy( |
Member
There was a problem hiding this comment.
for now we are still doing the writing through the persistenceStrategy?
Member
Author
There was a problem hiding this comment.
for now - yes. In the later PRs this will change: interface of DataWriter will change (and it won't be a single interface in the core) and for cross-feature interaction we will have message bus instead of getting the writer of another feature.
mariusc83
approved these changes
Oct 12, 2022
0xnm
deleted the
nogorodnikov/rumm-2536/use-v2-configuration-interface
branch
October 12, 2022 08:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change does the following decouples
SdkFeaturefrom RUM, Logs, etc. features.SdkFeaturewill reside in thecoremodule and won't be exposed as part of the public API, it is responsible forStorageandUploadercreation. RUM, Logs, etc. features will be in the independent modules.For now they take
Storageas a constructor argument, but later on they will only depend onSdkCoreand will do the writing operations using Event Write Context viaSdkCore#getFeature -> FeatureScope#withWriteContextcall.SdkFeatureimplementsFeatureScope.The idea is that
RumFeature,LogsFeature, etc. will be handling data serialization (since it is not the responsibility of thecore) and will write the binary data in the EWC, so for their ownPersistenceStrategyinterface we are leavingDataWriterpart only.DatadogFeatureclass is removed in favour ofSdkFeature.Features lifecycle API will be decided later.
Review checklist (to be filled by reviewers)