Skip to content

Merge Session Replay branch into SDK v2 branch#1075

Merged
0xnm merged 30 commits into
feature/sdkv2from
nogorodnikov/merge-sr-into-sdk-v2
Oct 7, 2022
Merged

Merge Session Replay branch into SDK v2 branch#1075
0xnm merged 30 commits into
feature/sdkv2from
nogorodnikov/merge-sr-into-sdk-v2

Conversation

@0xnm

@0xnm 0xnm commented Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR does a merge of feature/session-replay-v0 branch into feature/sdkv2 branch with all the issues resolved.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

mariusc83 added 29 commits October 6, 2022 16:54
@mariusc83
RUMM-2263 Setup dd-sdk-android-session-replay module
66363d4
@mariusc83
Move session replay module into library folder
0ce23e1
@mariusc83
Add the Session Replay Public API
50ed5a5
@mariusc83
RUMM-2335 Add Session Replay Public API tests
1140249
@mariusc83
RUMM-2330 Generate Pokos from Session Replay Json schemas
470487a
@mariusc83
RUMM-2335 Integrate Session Replay Hooks with the feature Public API
d6af2dd
@mariusc83
RUMM-2335 Add Session Replay hooks into the application lifecycle
aa6a521
@mariusc83
Small fix in the schema generator tasks
9d68665
@mariusc83
RUMM-2376 Modify the PokoGenerator to support root schema with no type
9c755c1
@mariusc83
RUMM-2376 Support and generate the new Session Replay schemas
2af3224
@mariusc83
Rebase on sdkv2 conflicts fixes
e9676ab
@mariusc83
RUMM-2356 Update Session Replay schemas
a272487
@mariusc83
RUMM-2356 Add Snapshot Producer first layer of logic
eca3c6e
@mariusc83
RUMM-2385 Intercept window touch events as Session Replay TouchData
65bb6f3
@mariusc83
RUMM-2421 Processor - process FullSnapshotRecords and dispatch to per…
13d6585 
…sister
@mariusc83
RUMM-2422 Process Session Replay touch and orientation change events
c3100c6
@mariusc83
RUMM-2423 SnapshotProcessor - process wireframe mutations
0365e58
@mariusc83
RUMM-2423 Add the Sesion Replay MASK_ALL/ALLOW_ALL privacy strategies
71e56b1
@mariusc83
RUMM-2494 Use View hashcode as unique identifier for mapped Wireframe
a7b4633
@mariusc83
RUMM-2497 SnapshotProcessor - do not write anything if there was no m…
1ac62ff 
…utation resolved
@mariusc83
RUMM-2273 Create the Session Replay Writer component
c865719
@mariusc83
RUMM-2542 Send hasReplay property for RUM events
5d8f606
@mariusc83
Update Session Replay schemas
3fda52d
@mariusc83
Add the Session Replay payload uploader
efdce6b
@mariusc83
Add session replay staging config to Sample App
d75c013
@mariusc83
RUMM-2510 Fix the mutation resolver alg based on the Heckels definition
7105572
@mariusc83
RUMM-2400 Use RUM timestamp offset when resolving Session Replay time…
c073bea 
…stamp
@mariusc83
Fixes after rebase on sdkv2 branch
30304b4
@mariusc83
RUMM-2562 Correct the way we handle orientation change events in SR
46e9ed4
@0xnm
0xnm requested a review from a team as a code owner October 6, 2022 15:45
@0xnm
0xnm requested a review from a team as a code owner October 6, 2022 15:45
mariusc83
mariusc83 approved these changes Oct 6, 2022
View reviewed changes

@mariusc83 mariusc83 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xnm
0xnm force-pushed the nogorodnikov/merge-sr-into-sdk-v2 branch from 652ed63 to 56890c3 Compare October 6, 2022 15:56
@codecov-commenter

codecov-commenter commented Oct 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.91571% with 241 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.46%. Comparing base (f5dd448) to head (56890c3).

Files with missing lines Patch % Lines
...replay/internal/net/SessionReplayOkHttpUploader.kt 5.26% 125 Missing and 1 partial ⚠️
...ndroid/sessionreplay/processor/MutationResolver.kt 86.13% 7 Missing and 12 partials ⚠️
...lay/internal/domain/SessionReplayRequestFactory.kt 13.33% 12 Missing and 1 partial ⚠️
...id/sessionreplay/internal/NoOpLifecycleCallback.kt 10.00% 9 Missing ⚠️
...droid/sessionreplay/net/BatchesToSegmentsMapper.kt 85.71% 7 Missing and 1 partial ⚠️
...android/sessionreplay/recorder/SnapshotProducer.kt 78.12% 0 Missing and 7 partials ⚠️
...droid/sessionreplay/processor/SnapshotProcessor.kt 93.75% 2 Missing and 4 partials ⚠️
...ssionreplay/recorder/mapper/TextWireframeMapper.kt 90.16% 2 Missing and 4 partials ⚠️
...oid/sessionreplay/utils/SessionReplayRumContext.kt 58.33% 0 Missing and 5 partials ⚠️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 33.33% 3 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files 
@@                Coverage Diff                @@
##           feature/sdkv2    #1075      +/-   ##
=================================================
- Coverage          82.96%   82.46%   -0.50%     
=================================================
  Files                306      347      +41     
  Lines              10158    11194    +1036     
  Branches            1658     1844     +186     
=================================================
+ Hits                8427     9231     +804     
- Misses              1219     1382     +163     
- Partials             512      581      +69
Files with missing lines Coverage Δ
...main/kotlin/com/datadog/android/DatadogEndpoint.kt 0.00% <ø> (ø)
...ndroid/core/internal/net/GzipRequestInterceptor.kt 80.00% <100.00%> (+2.73%) ⬆️
.../main/kotlin/com/datadog/android/plugin/Feature.kt 100.00% <100.00%> (ø)
...og/android/rum/internal/FeaturesContextResolver.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.75% <ø> (ø)
...ndroid/rum/internal/domain/scope/RumActionScope.kt 99.27% <100.00%> (+0.77%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 97.99% <100.00%> (+0.06%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 97.02% <100.00%> (+0.10%) ⬆️
...nal/tracking/AndroidXFragmentLifecycleCallbacks.kt 93.48% <ø> (ø)
...sionreplay/internal/SessionReplayRecordCallback.kt 100.00% <100.00%> (ø)
... and 46 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet xgouchet added the size-huge This PR is huge sized label Oct 6, 2022
cswatt
cswatt reviewed Oct 6, 2022
View reviewed changes

@cswatt cswatt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no docs review necessary 👍

@0xnm
0xnm merged commit 451d0cd into feature/sdkv2 Oct 7, 2022
@0xnm
0xnm deleted the nogorodnikov/merge-sr-into-sdk-v2 branch October 7, 2022 07:56
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cswatt cswatt cswatt left review comments
@mariusc83 mariusc83 mariusc83 approved these changes

Assignees

No one assigned

Labels

size-huge This PR is huge sized

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @cswatt @mariusc83 @xgouchet