RUMM-2562 Correct the way we handle orientation change events in SR#1073
Merged
mariusc83 merged 1 commit intoOct 6, 2022
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/session-replay-vo #1073 +/- ##
=============================================================
- Coverage 82.45% 82.41% -0.04%
=============================================================
Files 346 347 +1
Lines 11179 11180 +1
Branches 1849 1853 +4
=============================================================
- Hits 9217 9213 -4
- Misses 1378 1383 +5
Partials 584 584
🚀 New features to boost your workflow:
|
mariusc83
marked this pull request as ready for review
October 6, 2022 12:29
0xnm
approved these changes
Oct 6, 2022
| } | ||
|
|
||
| private fun isLastFullSnapshotTime(): Boolean { | ||
| private fun resolveIsFullSnapshotTime(): Boolean { |
Member
There was a problem hiding this comment.
nit: maybe isTimeForFullSnapshort (but yeah , this may not sound better)?
| } | ||
|
|
||
| private fun isNewView( | ||
| private fun resolveIsNewView( |
Member
There was a problem hiding this comment.
why do we rename this? imo without resolve it also looks reasonable.
mariusc83
force-pushed
the
mconstantin/rumm-2562/correctly-handle-orientation-change-events
branch
from
October 6, 2022 13:54
404a00e to
87fc25d
Compare
mariusc83
deleted the
mconstantin/rumm-2562/correctly-handle-orientation-change-events
branch
October 6, 2022 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the way we are handling the orientation change for Session Replay. Previously we were handling this in a separated flow which introduced a new state into the
SnapshotProcessorcausing problems regarding thenew viewdetection and the order of the records. With this new approach we are handling theOrientationChangedevent in the same stack used for handling the screen snapshot and by doing this we eliminate the potential issues resulting from introducing a new state for theSnapshotProcessor.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)