RUMM-2568: Remove DataReader v1 usages#1071
Merged
0xnm merged 1 commit intoOct 6, 2022
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sdkv2 #1071 +/- ##
=================================================
+ Coverage 83.16% 83.20% +0.04%
=================================================
Files 306 306
Lines 10176 10173 -3
Branches 1649 1649
=================================================
+ Hits 8462 8464 +2
+ Misses 1213 1209 -4
+ Partials 501 500 -1
🚀 New features to boost your workflow:
|
mariusc83
approved these changes
Oct 6, 2022
| } | ||
|
|
||
| @Test | ||
| fun `𝕄 delete everything 𝕎 dropAll() { there is locked batch }`( |
Member
There was a problem hiding this comment.
I am not seeing where you assert the removed locked batches...am I missing something ?
Member
Author
There was a problem hiding this comment.
that is true, there is no assertion of this internal state. We just rely that file was removed.
To assert this we need to make lockedBatches field internal and Batch class as well.
Base automatically changed from
nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature
to
feature/sdkv2
October 6, 2022 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the remaining usages of
DataReaderused in v1, because we are now usingStoragefor reading raw data and de-serialization is not needed anyway.Review checklist (to be filled by reviewers)