Skip to content

RUMM-2563: Create storage and uploader outside of the feature#1070

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature
Oct 6, 2022
Merged

RUMM-2563: Create storage and uploader outside of the feature#1070
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature

Conversation

@0xnm

@0xnm 0xnm commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Storage and DataUploader are pulled outside of the feature-specific classes, because core module will be responsible for those two.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner October 5, 2022 11:27
@xgouchet xgouchet added the size-medium This PR is medium sized label Oct 5, 2022
@0xnm
0xnm force-pushed the nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature branch from 4051a19 to 86e2a3f Compare October 5, 2022 12:22
@codecov-commenter

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.13725% with 7 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (f5dd448) to head (86e2a3f).

Files with missing lines Patch % Lines
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 88.71% 0 Missing and 7 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           feature/sdkv2    #1070      +/-   ##
=================================================
+ Coverage          82.96%   83.16%   +0.20%     
=================================================
  Files                306      306              
  Lines              10158    10176      +18     
  Branches            1658     1649       -9     
=================================================
+ Hits                8427     8462      +35     
+ Misses              1219     1213       -6     
+ Partials             512      501      -11
Files with missing lines Coverage Δ
...in/com/datadog/android/core/internal/SdkFeature.kt 91.23% <100.00%> (-0.84%) ⬇️
...istence/file/batch/BatchFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...ror/internal/CrashReportFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...adog/android/error/internal/CrashReportsFeature.kt 96.77% <100.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 92.31% <100.00%> (ø)
.../log/internal/domain/LogFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.75% <100.00%> (ø)
.../rum/internal/domain/RumFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
...datadog/android/tracing/internal/TracingFeature.kt 93.33% <100.00%> (ø)
...g/internal/domain/TracesFilePersistenceStrategy.kt 100.00% <100.00%> (ø)
... and 5 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mariusc83
mariusc83 reviewed Oct 6, 2022
View reviewed changes
Comment thread dd-sdk-android/src/main/kotlin/com/datadog/android/v2/core/DatadogCore.kt
@0xnm
0xnm merged commit 3917047 into feature/sdkv2 Oct 6, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2563/create-storage-and-uploader-outside-of-the-feature branch October 6, 2022 12:53
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees

No one assigned

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @mariusc83 @xgouchet