Skip to content

RUMM-2559: Register V1 features as V2#1069

Merged
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2559/register-v1-features-as-v2
Oct 5, 2022
Merged

RUMM-2559: Register V1 features as V2#1069
0xnm merged 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2559/register-v1-features-as-v2

Conversation

@0xnm

@0xnm 0xnm commented Oct 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This change will register existing v1 features as v2 (they will be backed by the FeatureScope).

Implementation of registerFeature method is temporary, will be addressed in the further PRs.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner October 4, 2022 13:50
@xgouchet xgouchet added the size-medium This PR is medium sized label Oct 4, 2022
@codecov-commenter

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1069 (5555f8d) into feature/sdkv2 (757bb25) will increase coverage by 0.14%.
The diff coverage is 72.80%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1069      +/-   ##
=================================================
+ Coverage          82.87%   83.01%   +0.14%     
=================================================
  Files                306      306              
  Lines              10101    10158      +57     
  Branches            1648     1658      +10     
=================================================
+ Hits                8371     8432      +61     
+ Misses              1227     1215      -12     
- Partials             503      511       +8
Impacted Files Coverage Δ
.../android/error/internal/DatadogExceptionHandler.kt 85.71% <0.00%> (ø)
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 75.00% <0.00%> (-3.85%) ⬇️
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 84.75% <0.00%> (ø)
...n/kotlin/com/datadog/android/v2/api/SdkEndpoint.kt 0.00% <ø> (ø)
.../com/datadog/android/webview/DatadogEventBridge.kt 78.38% <0.00%> (ø)
.../android/core/internal/data/upload/UploadWorker.kt 85.71% <25.00%> (ø)
.../com/datadog/android/tracing/TracingInterceptor.kt 96.43% <50.00%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 71.43% <60.00%> (+7.43%) ⬆️
...n/kotlin/com/datadog/android/DatadogInterceptor.kt 92.68% <66.67%> (ø)
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 74.47% <69.23%> (ø)
... and 35 more

@0xnm
0xnm merged commit f5dd448 into feature/sdkv2 Oct 5, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2559/register-v1-features-as-v2 branch October 5, 2022 08:28
@xgouchet xgouchet added this to the 1.16.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83