Skip to content

RUMM-2400 Use RUM timestamp offset when resolving Session Replay time…#1068

Merged
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events
Oct 5, 2022
Merged

RUMM-2400 Use RUM timestamp offset when resolving Session Replay time…#1068
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events

Conversation

@mariusc83

@mariusc83 mariusc83 commented Oct 4, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

In this PR we are applying the correct time offset provided from the RumViewScope when resolving the timestamp for the Session Replay events.

For this purpose we are introducing a new method in the SdkCore interface -> updateFeatureContext which updates the existing feature context or adds a new one (if it doesn't exist) with the provided key -> value pairs.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Oct 4, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events branch 2 times, most recently from 948e51e to bd11af3 Compare October 4, 2022 09:48
@xgouchet xgouchet added the size-medium This PR is medium sized label Oct 4, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events branch from bd11af3 to 799bc84 Compare October 4, 2022 10:26
@mariusc83
mariusc83 marked this pull request as ready for review October 4, 2022 10:49
@mariusc83
mariusc83 requested a review from a team as a code owner October 4, 2022 10:49
@codecov-commenter

codecov-commenter commented Oct 4, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1068 (e0b987c) into feature/session-replay-vo (0bf8401) will decrease coverage by 0.01%.
The diff coverage is 89.47%.

@@                      Coverage Diff                      @@
##           feature/session-replay-vo    #1068      +/-   ##
=============================================================
- Coverage                      82.26%   82.24%   -0.01%     
=============================================================
  Files                            346      346              
  Lines                          11108    11123      +15     
  Branches                        1837     1842       +5     
=============================================================
+ Hits                            9137     9148      +11     
- Misses                          1394     1399       +5     
+ Partials                         577      576       -1
Impacted Files Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.67% <ø> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 66.67% <0.00%> (-0.49%) ⬇️
...og/android/v2/core/internal/NoOpContextProvider.kt 4.35% <ø> (ø)
...id/sessionreplay/SessionReplayLifecycleCallback.kt 93.75% <ø> (-0.19%) ⬇️
...nreplay/internal/time/SessionReplayTimeProvider.kt 88.89% <88.89%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 97.02% <100.00%> (+0.03%) ⬆️
...oid/sessionreplay/internal/SessionReplayFeature.kt 95.12% <100.00%> (+0.12%) ⬆️
...sionreplay/internal/SessionReplayRecordCallback.kt 100.00% <100.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 82.81% <100.00%> (+0.85%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 83.60% <0.00%> (-4.23%) ⬇️
... and 6 more

@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2510/resolve-mutations-when-elements-order-changed branch 2 times, most recently from 68a4e49 to e625eac Compare October 5, 2022 12:46
Base automatically changed from mconstantin/rumm-2510/resolve-mutations-when-elements-order-changed to feature/session-replay-vo October 5, 2022 13:06
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events branch from 799bc84 to e0b987c Compare October 5, 2022 13:29
@mariusc83
mariusc83 merged commit 85467ae into feature/session-replay-vo Oct 5, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2400/apply-correct-timestamp-offset-to-replay-events branch October 5, 2022 14:32
@xgouchet xgouchet added this to the internal milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mariusc83 mariusc83

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

internal

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @xgouchet @0xnm