Minor performance optimization during serialization into JSON format#1066
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1066 +/- ##
===========================================
+ Coverage 83.24% 83.26% +0.02%
===========================================
Files 272 272
Lines 9279 9279
Branches 1494 1494
===========================================
+ Hits 7724 7726 +2
+ Misses 1140 1138 -2
Partials 415 415 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed a small issue in the related code: since
JsonArrayactually implementsIterable,is JsonArraybranch will never be executed, because it goes afteris Iterablebranch.By moving
is JsonArrayup we skip uselesstoJsonArraycall which will create new object and copy elements there from the old object.Review checklist (to be filled by reviewers)