RUMM-2775 Add Session Replay Uploader#1063
Merged
mariusc83 merged 3 commits intoOct 3, 2022
Merged
Conversation
0xnm
reviewed
Sep 29, 2022
| return if (body == null || originalRequest.header(HEADER_ENCODING) != null) { | ||
| return if (body == null || | ||
| originalRequest.header(HEADER_ENCODING) != null || | ||
| body is MultipartBody |
Member
There was a problem hiding this comment.
we skip Gzip compression, because body is already Gzipped in this case? shouldn't we then add a header (encoding?) saying that it is gzipped? because generally speaking MultipartBody (not from SR) can be in plain as well.
Member
Author
There was a problem hiding this comment.
yeah I was actually thinking to this but then I will have to change a bit more this logic to go through all the multipart bodies. Let me see if I can do something about it.
| internal class BatchesToSegmentsMapper { | ||
|
|
||
| fun map(batchData: List<ByteArray>): List<Pair<MobileSegment, JsonObject>> { | ||
| return groupBatchDataIntoSegments(batchData) |
Member
There was a problem hiding this comment.
minor: probably can just inline groupBatchDataIntoSegments here. This method does nothing else than calling another method.
| BytesCompressor.CHECKSUM_FLAG_SIZE_IN_BYTES | ||
| ) | ||
| ) | ||
| decompressor.finished() |
Member
There was a problem hiding this comment.
why do we need this call? per documentation it seems it doesn't modify anything, just returns the state.
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #1063 +/- ##
=============================================================
- Coverage 83.36% 82.35% -1.01%
=============================================================
Files 343 346 +3
Lines 10791 11042 +251
Branches 1792 1814 +22
=============================================================
+ Hits 8995 9093 +98
- Misses 1239 1385 +146
- Partials 557 564 +7
|
xgouchet
approved these changes
Oct 3, 2022
xgouchet
self-requested a review
October 3, 2022 08:26
mariusc83
force-pushed
the
mconstantin/rumm-2275/session-replay-uploader
branch
2 times, most recently
from
October 3, 2022 11:06
7b3ed5b to
294ab95
Compare
0xnm
requested changes
Oct 3, 2022
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
I've added some new comments (plus there are some comments from the previous round), but overall seems good! Just few final edits are needed.
Comment on lines
+17
to
+20
| /** Maps a batch to a List<Pair<MobileSegment, SerializedMobileSegment>> for uploading. | ||
| * This class is meant for internal usage. | ||
| */ |
Member
There was a problem hiding this comment.
A bit of formatting
Suggested change
| /** Maps a batch to a List<Pair<MobileSegment, SerializedMobileSegment>> for uploading. | |
| * This class is meant for internal usage. | |
| */ | |
| /** | |
| * Maps a batch to a List<Pair<MobileSegment, SerializedMobileSegment>> for uploading. | |
| * This class is meant for internal usage. | |
| */ |
Comment on lines
+12
to
+15
| /** Compresses the payload data using the ZIP compression algorithm. | ||
| * This class is meant for internal usage. | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** Compresses the payload data using the ZIP compression algorithm. | |
| * This class is meant for internal usage. | |
| */ | |
| /** | |
| * Compresses the payload data using the ZIP compression algorithm. | |
| * This class is meant for internal usage. | |
| */ |
mariusc83
force-pushed
the
mconstantin/rumm-2275/session-replay-uploader
branch
from
October 3, 2022 13:58
294ab95 to
477ff88
Compare
mariusc83
force-pushed
the
mconstantin/rumm-2275/session-replay-uploader
branch
from
October 3, 2022 14:08
477ff88 to
e0418fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we are adding the logic for reading the Session Replay batches, group them into Segments by RUM context and send them as separated payloads.
Note for reviewers: We are using an intermediary hack for now to use the new SDK V2
RequestFactory->SessionReplayOkHttpUploader. This class and the logic inside will be eventually migrated in theSessionReplayRequestFactoryonce thebatch to multiple requestsfeature will be available in SDK v2.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)