Skip to content

Update AGP to 7.3.0#1060

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/update-to-agp-7.3.0
Oct 3, 2022
Merged

Update AGP to 7.3.0#1060
0xnm merged 1 commit into
developfrom
nogorodnikov/update-to-agp-7.3.0

Conversation

@0xnm

@0xnm 0xnm commented Sep 28, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This change updates AGP version to 7.3.0, because we didn't update AGP for quite a long time.

The notable change is that package attribute shouldn't be used in the manifest, instead namespace property should be used in the module-level build.gradle. More here.

Also bumps Realm version.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner September 28, 2022 09:38
@codecov-commenter

codecov-commenter commented Sep 29, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1060 (fd6bff9) into develop (df4b21c) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1060      +/-   ##
===========================================
+ Coverage    83.19%   83.23%   +0.04%     
===========================================
  Files          272      272              
  Lines         9268     9279      +11     
  Branches      1488     1494       +6     
===========================================
+ Hits          7710     7723      +13     
+ Misses        1144     1140       -4     
- Partials       414      416       +2
Impacted Files Coverage Δ
...n/kotlin/com/datadog/android/timber/DatadogTree.kt 50.00% <0.00%> (-5.56%) ⬇️
...tadog/android/tv/LeanbackViewAttributesProvider.kt 86.21% <0.00%> (-2.68%) ⬇️
...main/java/com/datadog/exec/CommonTaskExecutor.java 47.92% <0.00%> (-2.08%) ⬇️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 87.57% <0.00%> (-1.08%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 91.33% <0.00%> (-0.58%) ⬇️
...main/kotlin/com/datadog/android/rx/DatadogRxExt.kt 100.00% <0.00%> (ø)
...tadog/android/fresco/DatadogFrescoCacheListener.kt 100.00% <0.00%> (ø)
...kotlin/com/datadog/android/DatadogEventListener.kt 98.51% <0.00%> (+0.02%) ⬆️
.../src/main/kotlin/com/datadog/android/log/Logger.kt 96.03% <0.00%> (+0.03%) ⬆️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (+0.84%) ⬆️
... and 3 more

@0xnm
0xnm merged commit 7df131c into develop Oct 3, 2022
@0xnm
0xnm deleted the nogorodnikov/update-to-agp-7.3.0 branch October 3, 2022 08:14
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83