Skip to content

Cherry-pick: Support sending CPU architecture as part of device info#1057

Merged
0xnm merged 1 commit into
release/1.14.0from
nogorodnikov/cherry-pick-device-arch-into-1.14.0
Sep 28, 2022
Merged

Cherry-pick: Support sending CPU architecture as part of device info#1057
0xnm merged 1 commit into
release/1.14.0from
nogorodnikov/cherry-pick-device-arch-into-1.14.0

Conversation

@0xnm

@0xnm 0xnm commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Cherry-pick of #1000 into 1.14.0 release branch. This is needed to enable error tracking support for Flutter.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary @0xnm
Support sending CPU architecture as part of device info
79311a1 
This utilizes a partial update of the RUM event schema to include 'architecture' but not some other changes in the most up to date schema, essentially putting it in a 'detached HEAD' state.
Architecture is taken from String.getProperty("os.arch") over Build.CPU_ABI both because CPU_ABI is deprecated and because os.arch appears to give us a result closer to what we want, without including the name of the CPU.
@0xnm
0xnm requested a review from a team as a code owner September 27, 2022 13:38
@0xnm 0xnm mentioned this pull request Sep 27, 2022
Merged
3 tasks
@0xnm
0xnm changed the base branch from develop to release/1.14.0 September 27, 2022 13:56
@xgouchet xgouchet added the size-medium This PR is medium sized label Sep 27, 2022
@codecov-commenter

codecov-commenter commented Sep 27, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1057 (79311a1) into release/1.14.0 (6fede7a) will decrease coverage by 0.02%.
The diff coverage is 94.44%.

@@                Coverage Diff                 @@
##           release/1.14.0    #1057      +/-   ##
==================================================
- Coverage           83.16%   83.14%   -0.02%     
==================================================
  Files                 272      272              
  Lines                9280     9305      +25     
  Branches             1493     1501       +8     
==================================================
+ Hits                 7717     7736      +19     
- Misses               1155     1157       +2     
- Partials              408      412       +4
Impacted Files Coverage Δ
...core/internal/system/DefaultAndroidInfoProvider.kt 82.61% <0.00%> (-1.84%) ⬇️
...id/core/internal/system/NoOpAndroidInfoProvider.kt 100.00% <100.00%> (ø)
...ndroid/rum/internal/domain/scope/RumActionScope.kt 98.44% <100.00%> (+0.01%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 97.91% <100.00%> (+0.02%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 96.90% <100.00%> (+0.03%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.11% <100.00%> (-1.02%) ⬇️
...android/log/internal/logger/TelemetryLogHandler.kt 75.00% <0.00%> (-25.00%) ⬇️
...n/kotlin/com/datadog/android/timber/DatadogTree.kt 50.00% <0.00%> (-5.56%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.65% <0.00%> (-0.42%) ⬇️
... and 8 more

@0xnm
0xnm merged commit 01d1068 into release/1.14.0 Sep 28, 2022
@0xnm
0xnm deleted the nogorodnikov/cherry-pick-device-arch-into-1.14.0 branch September 28, 2022 09:30
@xgouchet xgouchet added this to the 1.14.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzzybinary fuzzybinary fuzzybinary approved these changes
@mariusc83 mariusc83 mariusc83 approved these changes

Assignees

No one assigned

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @fuzzybinary @mariusc83 @xgouchet