Skip to content

RUMM-2545: Feature-specific upload factory should have no-arg constructor#1055

Closed
0xnm wants to merge 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2545/feature-specific-upload-factory-should-have-no-arg-constructor
Closed

RUMM-2545: Feature-specific upload factory should have no-arg constructor#1055
0xnm wants to merge 1 commit into
feature/sdkv2from
nogorodnikov/rumm-2545/feature-specific-upload-factory-should-have-no-arg-constructor

Conversation

@0xnm

@0xnm 0xnm commented Sep 26, 2022

Copy link
Copy Markdown
Member

What does this PR do?

First PR in a series of PR whose goal is to align features configuration with SDK v2.

This change makes feature-specific request factories to have no-arg constructor, considering they should get everything they need from DatadogContext.

Also this change updates the tests of DatadogCore related to the additional configuration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
RUMM-2545: Feature-specific upload factory should have no-arg constru…
800cae4 
…ctor, fix DatadogCore additional configuration tests
@0xnm
0xnm requested a review from a team as a code owner September 26, 2022 11:52
@codecov-commenter

codecov-commenter commented Sep 26, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1055 (800cae4) into feature/sdkv2 (757bb25) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           feature/sdkv2    #1055      +/-   ##
=================================================
+ Coverage          82.87%   82.96%   +0.08%     
=================================================
  Files                306      306              
  Lines              10101    10098       -3     
  Branches            1648     1648              
=================================================
+ Hits                8371     8377       +6     
+ Misses              1227     1222       -5     
+ Partials             503      499       -4
Impacted Files Coverage Δ
...in/com/datadog/android/core/internal/SdkFeature.kt 92.06% <100.00%> (ø)
...adog/android/error/internal/CrashReportsFeature.kt 96.67% <100.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 91.67% <100.00%> (ø)
...lin/com/datadog/android/rum/internal/RumFeature.kt 91.67% <100.00%> (ø)
...datadog/android/tracing/internal/TracingFeature.kt 92.86% <100.00%> (ø)
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 71.20% <100.00%> (+7.20%) ⬆️
.../android/v2/log/internal/net/LogsRequestFactory.kt 100.00% <100.00%> (ø)
...g/android/v2/rum/internal/net/RumRequestFactory.kt 97.50% <100.00%> (-0.06%) ⬇️
...id/v2/tracing/internal/net/TracesRequestFactory.kt 100.00% <100.00%> (ø)
...android/webview/internal/log/WebViewLogsFeature.kt 100.00% <100.00%> (ø)
... and 9 more

@0xnm 0xnm closed this Sep 27, 2022
@0xnm 0xnm mentioned this pull request Sep 27, 2022
Merged
3 tasks
@0xnm
0xnm deleted the nogorodnikov/rumm-2545/feature-specific-upload-factory-should-have-no-arg-constructor branch November 25, 2022 15:06
@xgouchet xgouchet added this to the Dropped milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Dropped

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet