RUMM-2542 Send hasReplay property for RUM events#1054
Merged
mariusc83 merged 1 commit intoSep 26, 2022
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2542/send-has-replay-true-for-rum-when-recording
branch
2 times, most recently
from
September 23, 2022 13:51
9de000f to
580b8d0
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #1054 +/- ##
=============================================================
+ Coverage 83.26% 83.35% +0.08%
=============================================================
Files 332 343 +11
Lines 10569 10791 +222
Branches 1773 1792 +19
=============================================================
+ Hits 8800 8994 +194
- Misses 1219 1243 +24
- Partials 550 554 +4
|
mariusc83
force-pushed
the
mconstantin/rumm-2542/send-has-replay-true-for-rum-when-recording
branch
2 times, most recently
from
September 23, 2022 14:26
1dc5b2f to
99d17a7
Compare
mariusc83
marked this pull request as ready for review
September 23, 2022 14:32
0xnm
approved these changes
Sep 25, 2022
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm. I just added one comment regarding the assertion removed from the test.
| assertThat(testedCore.webViewRumFeature).isNull() | ||
| assertThat(testedCore.crashReportsFeature).isNull() | ||
| assertThat(testedCore.sessionReplayFeature).isNull() | ||
| assertThat(testedCore.contextProvider).isNull() |
Member
There was a problem hiding this comment.
why this line is removed? In the latest version of the SDK v2 branch at least when CoreFeature is stopped, contextProvider should return null.
xgouchet
approved these changes
Sep 26, 2022
mariusc83
force-pushed
the
mconstantin/rumm-2542/send-has-replay-true-for-rum-when-recording
branch
from
September 26, 2022 07:45
99d17a7 to
76ec178
Compare
mariusc83
deleted the
mconstantin/rumm-2542/send-has-replay-true-for-rum-when-recording
branch
September 26, 2022 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)