RUMM-2504: Switch to the SDK v2 storage component#1051
Merged
0xnm merged 1 commit intoSep 23, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1051 +/- ##
=================================================
+ Coverage 82.83% 82.84% +0.02%
=================================================
Files 306 306
Lines 10080 10089 +9
Branches 1642 1645 +3
=================================================
+ Hits 8349 8358 +9
Misses 1230 1230
Partials 501 501
|
xgouchet
approved these changes
Sep 21, 2022
0xnm
force-pushed
the
nogorodnikov/rumm-2504/switch-to-sdkv2-storage
branch
from
September 21, 2022 12:42
5659de8 to
c059e6b
Compare
mariusc83
reviewed
Sep 22, 2022
| val context = contextProvider.context | ||
| val eventId = System.identityHashCode(data).toString() | ||
| storage.writeCurrentBatch(context) { | ||
| pendingWriteEvents[eventId] = data to byteArray |
Member
There was a problem hiding this comment.
aren't we concerned that we will keep too much data in HEAP ?
Member
Author
There was a problem hiding this comment.
Good question. For now we need to store both event and serialized event mostly because of the RUM, but maybe later on with once RUM will start using write scope to perform writes we can change it.
What is your expectation for the memory pressure during SR? How often and how big are going to be events received? I guess concern is mostly because of the bitmaps?
I would propose to add TODO for now. WDYT?
Member
There was a problem hiding this comment.
Yes I am mostly thinking for Bitmaps here, let's benchmark this when we get there and see how it goes.
mariusc83
approved these changes
Sep 23, 2022
0xnm
force-pushed
the
nogorodnikov/rumm-2504/switch-to-sdkv2-storage
branch
from
September 23, 2022 08:41
c059e6b to
00b79be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change does a switch to the
Storageimplementation written earlier. While it is not used as it should be in the feature configuration per SDK v2 plan, this change helps to minimize the diff of the transition and makes a proof that new component works.Review checklist (to be filled by reviewers)