RUMM-2501: Use SDK v2 components in the upload pipeline#1040
Merged
0xnm merged 2 commits intoSep 20, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1040 +/- ##
=================================================
- Coverage 82.89% 82.86% -0.03%
=================================================
Files 301 306 +5
Lines 9951 10080 +129
Branches 1637 1642 +5
=================================================
+ Hits 8248 8352 +104
- Misses 1207 1229 +22
- Partials 496 499 +3
|
mariusc83
requested changes
Sep 15, 2022
mariusc83
approved these changes
Sep 15, 2022
xgouchet
approved these changes
Sep 19, 2022
0xnm
force-pushed
the
nogorodnikov/rumm-2501/use-sdkv2-components-in-upload-pipeline
branch
from
September 20, 2022 07:35
cac35df to
2831cc9
Compare
0xnm
deleted the
nogorodnikov/rumm-2501/use-sdkv2-components-in-upload-pipeline
branch
September 20, 2022 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a transitional PR (some things are not final) which makes the usage of SDK v2 components in the upload pipeline.
Namely we now are using
Storagefor the batch reads andRequestFactoryas well.Some content inside the implementations of
RequestFactoryfor RUM, Logs and Traces is duplicated, but this is on purpose, because later on these classes will be split into different modules.Review checklist (to be filled by reviewers)