Skip to content

RUMM-2497 SnapshotProcessor - do not write anything if there was no mutation detected#1038

Merged
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2497/do-not-write-record-if-no-mutations
Sep 14, 2022
Merged

RUMM-2497 SnapshotProcessor - do not write anything if there was no mutation detected#1038
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2497/do-not-write-record-if-no-mutations

Conversation

@mariusc83

@mariusc83 mariusc83 commented Sep 12, 2022

Copy link
Copy Markdown
Member

…utation resolved

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Sep 12, 2022
@mariusc83
mariusc83 requested a review from a team as a code owner September 12, 2022 09:04
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2497/do-not-write-record-if-no-mutations branch from 7540c61 to 8d788b5 Compare September 12, 2022 09:04
@xgouchet xgouchet added the size-small This PR is small sized label Sep 12, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2497/do-not-write-record-if-no-mutations branch from 8d788b5 to 35c40fb Compare September 12, 2022 09:48
@mariusc83 mariusc83 changed the title RUMM-2497 SnapshotProcessor - do not write anything if there was no m… RUMM-2497 SnapshotProcessor - do not write anything if there was no mutation detected Sep 12, 2022
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2497/do-not-write-record-if-no-mutations branch from 35c40fb to b286d98 Compare September 12, 2022 11:57
@mariusc83
mariusc83 merged commit a710a59 into feature/session-replay-vo Sep 14, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2497/do-not-write-record-if-no-mutations branch September 14, 2022 07:44
@xgouchet xgouchet added this to the internal milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-small This PR is small sized

Projects

None yet

Milestone

internal

Development

Successfully merging this pull request may close these issues.

3 participants

@mariusc83 @0xnm @xgouchet