RUMM-2333: Features can store their context in SDK context#1036
Merged
0xnm merged 1 commit intoSep 9, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/sdkv2 #1036 +/- ##
=================================================
+ Coverage 82.89% 82.90% +0.01%
=================================================
Files 301 301
Lines 9947 9951 +4
Branches 1636 1637 +1
=================================================
+ Hits 8245 8249 +4
+ Misses 1206 1205 -1
- Partials 496 497 +1
|
mariusc83
reviewed
Sep 8, 2022
| fakeProcessImportance = forge.anInt() | ||
| // building nested maps with default size slows down tests quite a lot, so will use | ||
| // an explicit small size | ||
| fakeFeaturesContext = forge.aMap(size = 2) { |
| ) | ||
| } | ||
|
|
||
| override fun setFeatureContext(feature: String, context: Map<String, Any?>) { |
Member
There was a problem hiding this comment.
Looks a bit weird to have this function in the ContextProvider. Why not having it in the SdkCore ?
Member
Author
There was a problem hiding this comment.
to be aligned with iOS which is using ContextProvider for that https://github.com/DataDog/dd-sdk-ios/pull/988/files#diff-3a832cfb97bddffab83c8a48d337c2e51541efa821f7befd8cc3c9b7944047eaR145
mariusc83
approved these changes
Sep 8, 2022
xgouchet
approved these changes
Sep 9, 2022
0xnm
deleted the
nogorodnikov/rumm-2333/features-can-store-their-context
branch
September 9, 2022 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A small change allowing features to store their context in the SDK context. The actual usage and (maybe) subscription model for the changes will come later.
Review checklist (to be filled by reviewers)