Skip to content

RUMM-2353: Report frustration count on views#1030

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2353/report-frustration-count-on-views
Sep 2, 2022
Merged

RUMM-2353: Report frustration count on views#1030
0xnm merged 1 commit into
developfrom
nogorodnikov/rumm-2353/report-frustration-count-on-views

Conversation

@0xnm

@0xnm 0xnm commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This change adds view.frustration.count data point, which is a total count of the all the frustrations happened in all the nested actions.

To support this I've changed EventType enum to the sealed class, so it is possible to send a payload on the data storage notification loopback.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner September 1, 2022 15:12
@codecov-commenter

codecov-commenter commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.22222% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.10%. Comparing base (639d58e) to head (157e679).
⚠️ Report is 4099 commits behind head on develop.

Files with missing lines Patch % Lines
.../android/rum/internal/monitor/DatadogRumMonitor.kt 73.68% 2 Missing and 3 partials ⚠️
...tadog/android/rum/internal/domain/RumDataWriter.kt 87.50% 0 Missing and 1 partial ⚠️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 85.71% 0 Missing and 1 partial ⚠️
...tadog/android/rum/internal/monitor/StorageEvent.kt 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1030      +/-   ##
===========================================
+ Coverage    83.08%   83.10%   +0.02%     
===========================================
  Files          272      272              
  Lines         9235     9248      +13     
  Branches      1471     1483      +12     
===========================================
+ Hits          7672     7685      +13     
+ Misses        1147     1146       -1     
- Partials       416      417       +1
Files with missing lines Coverage Δ
...g/android/rum/internal/domain/scope/RumRawEvent.kt 82.55% <100.00%> (+0.12%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 96.91% <100.00%> (+0.01%) ⬆️
...tadog/android/rum/internal/domain/RumDataWriter.kt 85.71% <87.50%> (-2.75%) ⬇️
...ndroid/rum/internal/domain/event/RumEventMapper.kt 94.00% <85.71%> (-1.83%) ⬇️
...tadog/android/rum/internal/monitor/StorageEvent.kt 85.71% <85.71%> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 92.49% <73.68%> (-0.37%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet xgouchet added the size-small This PR is small sized label Sep 1, 2022
@0xnm
0xnm merged commit 520d778 into develop Sep 2, 2022
@0xnm
0xnm deleted the nogorodnikov/rumm-2353/report-frustration-count-on-views branch September 2, 2022 07:10
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size-small This PR is small sized

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83