Add configuration method to disable action tracking.#1023
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1023 +/- ##
===========================================
+ Coverage 83.12% 83.23% +0.10%
===========================================
Files 272 272
Lines 9256 9260 +4
Branches 1485 1485
===========================================
+ Hits 7694 7707 +13
+ Misses 1145 1139 -6
+ Partials 417 414 -3
🚀 New features to boost your workflow:
|
| ) | ||
| } | ||
|
|
||
| sendRandomActionEvent(testMethodName) |
There was a problem hiding this comment.
It seems we don't have a monitor for this test yet, right? Also I'm curious if we can test disableInteractionTracking at all - sendRandomActionEvent has no connection to this method it seems, because it will send a manual action, which is not guarded by the disableInteractionTracking.
There was a problem hiding this comment.
I was going to add the monitor after this is in, since creating it early would just cause some trigger noise.
Good call on the sendRandomAction. This is why I wanted you to re-review.
Do we have a method that does a non-manual action?
There was a problem hiding this comment.
good question. We can launch some activity and then use Espresso to make a tap on some element. And then if interactions tracking is disabled we shouldn't see it in RUM.
But maybe it is too much for such small method. I'm ok with removing E2E test as well. WDYT?
There was a problem hiding this comment.
If we're not too concerned about it, I'll remove the e2e.
1903c57 to
703a0c3
Compare
|
One more time for anyone who's interested. I've pulled out the e2e and marked the API as not testable. If I can get someone to just give a 👍 we'll merge this in. |
5 participants
What does this PR do?
This allows users to replace the current UserAcitonTrackingStategy with a NoOpUserActionTrackingStrategy.
Motivation
This is mostly for Flutter, since the initialization of the UserActionTrackingStrategy happens after the MainActivity is live, so the initial creation misses hooking into the Activity anyway, and subsequent attempts to listen to the Activity result in logcat spam, as there are no views that the tracking strategy can see.
Review checklist (to be filled by reviewers)