Use a gitlab template for analysis generated files check#1016
Merged
Conversation
daniel-m-dd
force-pushed
the
d.marin/ci-template
branch
from
August 19, 2022 05:38
8f4b663 to
5ab98e0
Compare
daniel-m-dd
commented
Aug 19, 2022
| script: | ||
| - GRADLE_OPTS="-Xmx2560m" ./gradlew checkApiSurfaceChangesAll --stacktrace --no-daemon | ||
| variables: | ||
| GRADLE_OPTS: "-Xmx2560m -Dorg.gradle.daemon=false -Porg.gradle.logging.stacktrace=full" |
Contributor
Author
There was a problem hiding this comment.
🤔 Should we let the template consumer setup the gradle configuration or should it be defined at the shared gitlab template level.
One issue we have here is we define the env variables for all jobs defined and run from the gitlab templates
(same thing regarding the timeout gitlab param)
Codecov Report
@@ Coverage Diff @@
## develop #1016 +/- ##
===========================================
+ Coverage 83.19% 83.21% +0.02%
===========================================
Files 270 270
Lines 9216 9216
Branches 1469 1469
===========================================
+ Hits 7667 7669 +2
- Misses 1137 1138 +1
+ Partials 412 409 -3
|
xgouchet
approved these changes
Aug 19, 2022
mariusc83
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use a defined gitlab template for all generated files status check
Successful run: https://gitlab.ddbuild.io/datadog/dd-sdk-android/builds/164093339
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)