Skip to content

RUMM-2422 Process Session Replay touch and orientation change events#1014

Merged
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2422/process-touchdata-and-orientation-change
Aug 31, 2022
Merged

RUMM-2422 Process Session Replay touch and orientation change events#1014
mariusc83 merged 1 commit into
feature/session-replay-vofrom
mconstantin/rumm-2422/process-touchdata-and-orientation-change

Conversation

@mariusc83

@mariusc83 mariusc83 commented Aug 17, 2022

Copy link
Copy Markdown
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Aug 17, 2022
@codecov-commenter

codecov-commenter commented Aug 17, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1014 (6b72c53) into mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords (82339be) will increase coverage by 0.05%.
The diff coverage is 92.98%.

@@                                        Coverage Diff                                         @@
##           mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords    #1014      +/-   ##
==================================================================================================
+ Coverage                                                           83.09%   83.14%   +0.05%     
==================================================================================================
  Files                                                                 320      320              
  Lines                                                               10296    10334      +38     
  Branches                                                             1697     1704       +7     
==================================================================================================
+ Hits                                                                 8555     8592      +37     
- Misses                                                               1207     1208       +1     
  Partials                                                              534      534
Impacted Files Coverage Δ
...d/sessionreplay/utils/SessionReplayTimeProvider.kt 100.00% <ø> (ø)
...oid/sessionreplay/utils/SessionReplayRumContext.kt 58.33% <33.33%> (-8.33%) ⬇️
...droid/sessionreplay/processor/SnapshotProcessor.kt 93.00% <96.30%> (+5.31%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (-0.42%) ⬇️
...src/main/kotlin/com/datadog/android/DatadogSite.kt 86.67% <0.00%> (ø)
...android/v2/core/internal/DatadogContextProvider.kt 81.03% <0.00%> (ø)
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 89.22% <0.00%> (+0.98%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 88.30% <0.00%> (+1.06%) ⬆️

@xgouchet xgouchet added the size-medium This PR is medium sized label Aug 17, 2022
@mariusc83
mariusc83 marked this pull request as ready for review August 17, 2022 17:02
@mariusc83
mariusc83 requested a review from a team as a code owner August 17, 2022 17:02
0xnm
0xnm approved these changes Aug 25, 2022
View reviewed changes
Comment thread ...on-replay/src/main/kotlin/com/datadog/android/sessionreplay/utils/SessionReplayRumContext.kt
sessionId == NULL_UUID ||
viewId == NULL_UUID

internal fun isValid(): Boolean =

@0xnm 0xnm Aug 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be simplified to !isNotValid

@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords branch 3 times, most recently from e82ac59 to bbbc4e6 Compare August 31, 2022 12:33
Base automatically changed from mconstantin/rumm-2421/process-snapshots-as-fullsnapshotrecords to feature/session-replay-vo August 31, 2022 12:54
@mariusc83
mariusc83 force-pushed the mconstantin/rumm-2422/process-touchdata-and-orientation-change branch from 6b72c53 to 147ccd7 Compare August 31, 2022 13:24
@mariusc83
mariusc83 merged commit 3a9b1c3 into feature/session-replay-vo Aug 31, 2022
@mariusc83
mariusc83 deleted the mconstantin/rumm-2422/process-touchdata-and-orientation-change branch August 31, 2022 13:52
@mariusc83
mariusc83 restored the mconstantin/rumm-2422/process-touchdata-and-orientation-change branch September 5, 2022 08:50
mariusc83 added a commit that referenced this pull request Sep 5, 2022
@mariusc83
Merge pull request #1014 from DataDog/mconstantin/rumm-2422/process-t…
4b981df 
…ouchdata-and-orientation-change

RUMM-2422 Process Session Replay touch and orientation change events
@mariusc83
mariusc83 deleted the mconstantin/rumm-2422/process-touchdata-and-orientation-change branch September 5, 2022 08:53
@xgouchet xgouchet added this to the internal milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

@mariusc83 mariusc83

Labels

size-medium This PR is medium sized

Projects

None yet

Milestone

internal

Development

Successfully merging this pull request may close these issues.

4 participants

@mariusc83 @codecov-commenter @0xnm @xgouchet