Skip to content

Replace references to iOS classes with correct Android equivalents.#1012

Merged
plousada merged 2 commits into
developfrom
plousada/correct-doc-classes
Aug 12, 2022
Merged

Replace references to iOS classes with correct Android equivalents.#1012
plousada merged 2 commits into
developfrom
plousada/correct-doc-classes

Conversation

@plousada

@plousada plousada commented Aug 10, 2022

Copy link
Copy Markdown
Member

What does this PR do?

Correct documentation containing references to iOS classes

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada
plousada requested review from a team and alai97 as code owners August 10, 2022 10:18
buraizu
buraizu requested changes Aug 10, 2022
View reviewed changes

@buraizu buraizu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just made some minor suggestions per our contributing guidelines:
https://github.com/DataDog/documentation/blob/master/CONTRIBUTING.md

Comment thread docs/mobile_data_collected.md Outdated
@codecov-commenter

codecov-commenter commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1012 (5bac997) into develop (0e76b2c) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1012      +/-   ##
===========================================
- Coverage    83.17%   83.13%   -0.03%     
===========================================
  Files          270      270              
  Lines         9213     9213              
  Branches      1464     1464              
===========================================
- Hits          7662     7659       -3     
  Misses        1141     1141              
- Partials       410      413       +3
Impacted Files Coverage Δ
...g/internal/domain/event/DdSpanToSpanEventMapper.kt 96.08% <0.00%> (-3.92%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 56.03% <0.00%> (-2.59%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 90.32% <0.00%> (-1.61%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 55.23% <0.00%> (-0.84%) ⬇️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 93.45% <0.00%> (+0.60%) ⬆️
...main/java/com/datadog/exec/CommonTaskExecutor.java 50.00% <0.00%> (+4.17%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (+10.00%) ⬆️

@plousada
plousada merged commit dccfa8a into develop Aug 12, 2022
@plousada
plousada deleted the plousada/correct-doc-classes branch August 12, 2022 09:21
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@buraizu buraizu buraizu approved these changes
@alai97 alai97 Awaiting requested review from alai97

Assignees

No one assigned

Labels

size-tiny

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@plousada @codecov-commenter @mariusc83 @buraizu @xgouchet