Skip to content

Fix buttons overlap in the sample app#1004

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-overlap-in-sample-app
Jul 29, 2022
Merged

Fix buttons overlap in the sample app#1004
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-overlap-in-sample-app

Conversation

@0xnm

@0xnm 0xnm commented Jul 28, 2022

Copy link
Copy Markdown
Member

What does this PR do?

This change fixes a minor UI glitch on the Home screen of the sample app: Jetpack Compose button was overlaying Picture Loading button.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested a review from a team as a code owner July 28, 2022 14:46
@codecov-commenter

codecov-commenter commented Jul 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1004 (0de02b2) into develop (f4498a5) will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1004      +/-   ##
===========================================
+ Coverage    83.19%   83.30%   +0.11%     
===========================================
  Files          270      270              
  Lines         9209     9209              
  Branches      1463     1463              
===========================================
+ Hits          7661     7671      +10     
+ Misses        1137     1133       -4     
+ Partials       411      405       -6     
Impacted Files Coverage Δ
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (+0.86%) ⬆️
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 89.19% <0.00%> (+2.16%) ⬆️
...nternal/persistence/file/batch/BatchFileHandler.kt 81.13% <0.00%> (+2.83%) ⬆️
...ndroid/core/internal/persistence/file/EventMeta.kt 90.00% <0.00%> (+10.00%) ⬆️

@0xnm
0xnm merged commit 72beeb9 into develop Jul 29, 2022
@0xnm
0xnm deleted the nogorodnikov/fix-overlap-in-sample-app branch July 29, 2022 08:13
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants