Skip to content

Update statement about default view tracking strategy in the docs#1003

Merged
0xnm merged 1 commit into
masterfrom
nogorodnikov/update-docs-about-rum-default-view-tracking
Aug 22, 2022
Merged

Update statement about default view tracking strategy in the docs#1003
0xnm merged 1 commit into
masterfrom
nogorodnikov/update-docs-about-rum-default-view-tracking

Conversation

@0xnm

@0xnm 0xnm commented Jul 28, 2022

Copy link
Copy Markdown
Member

What does this PR do?

#521 added sensible defaults to the RUM config, but docs were not updated. This PR fixes that.

Note: This PR is targeting master branch, because it is related to the functionality which was released a long time ago already. Once merged, it needs to be moved to develop as well.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners July 28, 2022 13:21
@codecov-commenter

codecov-commenter commented Jul 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1003 (20146ad) into master (c3138f4) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   83.13%   83.07%   -0.06%     
==========================================
  Files         267      267              
  Lines        9079     9079              
  Branches     1461     1461              
==========================================
- Hits         7547     7542       -5     
- Misses       1131     1132       +1     
- Partials      401      405       +4     
Impacted Files Coverage Δ
...android/rum/internal/ndk/DatadogNdkCrashHandler.kt 83.91% <0.00%> (-2.87%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 58.62% <0.00%> (-1.72%) ⬇️
...rc/main/java/com/datadog/opentracing/DDTracer.java 56.07% <0.00%> (ø)
...ndroid/core/internal/persistence/file/EventMeta.kt 80.00% <0.00%> (ø)
...droid/rum/tracking/ActivityViewTrackingStrategy.kt 88.46% <0.00%> (+1.92%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 100.00% <0.00%> (+25.00%) ⬆️

@0xnm
0xnm merged commit 8fc7485 into master Aug 22, 2022
@0xnm
0xnm deleted the nogorodnikov/update-docs-about-rum-default-view-tracking branch August 22, 2022 07:14
@xgouchet xgouchet added this to the 1.15.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants