RUMM-2372 Adapt PokoGenerator and Session Replay models generator to new schemas#1002
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rumm-2372/adapt-session-replay-schemas-generator-to-new-structure
branch
2 times, most recently
from
July 26, 2022 15:45
15950e3 to
1360359
Compare
Codecov Report
@@ Coverage Diff @@
## feature/session-replay-vo #1002 +/- ##
=============================================================
+ Coverage 82.81% 82.89% +0.08%
=============================================================
Files 306 306
Lines 9853 9852 -1
Branches 1616 1615 -1
=============================================================
+ Hits 8159 8166 +7
+ Misses 1190 1186 -4
+ Partials 504 500 -4
|
mariusc83
marked this pull request as ready for review
July 27, 2022 07:35
0xnm
reviewed
Jul 27, 2022
| "https://github.com/DataDog/rum-events-format.git", | ||
| "schemas/session-replay/mobile", | ||
| destinationFolder = "src/main/json/schemas/session-replay/mobile", | ||
| excludedPrefixes = listOf(), |
Member
There was a problem hiding this comment.
minor: default value is emptyList() anyway, so there is no need to specify this parameter explicitly
| "https://github.com/DataDog/rum-events-format.git", | ||
| "schemas/session-replay/common", | ||
| destinationFolder = "src/main/json/schemas/session-replay/common", | ||
| excludedPrefixes = listOf(), |
| fun readSchema(schemaFile: File): TypeDefinition { | ||
| logger.info("Reading schema ${schemaFile.name}") | ||
| val schema = loadSchema(schemaFile) | ||
| require(schema.type == JsonType.OBJECT) { |
Member
There was a problem hiding this comment.
why this is removed if no changes are done to the reader logic?
Member
Author
There was a problem hiding this comment.
is to support the special case I added in the tests. Is because the browser team needed this in the schemas and we are sharing that with them.
Member
There was a problem hiding this comment.
ok, just wanted to make sure things work as expected in the JsonSchemaReader for the schema.type != JsonType.OBJECT case
Member
Author
There was a problem hiding this comment.
Yes, apparently they work, I still need to ask Xavier why he added this there in the first place. Maybe it was a constraint in the beginning.
0xnm
approved these changes
Jul 27, 2022
mariusc83
force-pushed
the
mconstantin/rumm-2372/adapt-session-replay-schemas-generator-to-new-structure
branch
from
July 27, 2022 11:12
1360359 to
0a1a561
Compare
mariusc83
deleted the
mconstantin/rumm-2372/adapt-session-replay-schemas-generator-to-new-structure
branch
July 27, 2022 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Session Replay schemas structure was modified in order to support also the browser events format.
We had to adapt our PokoGenerator to support a root schema for which the type is resolved from a referenced schema.
We also had to change/adapt our models generator Gradle tasks in the
dd-sdk-android-session-replaymodule.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)