Describe what happened
After adding the Datadog SDK (com.datadoghq:dd-sdk-android) to my app, I noticed that the app size increased by more than I expected.
Steps to reproduce the issue:
Add the Datadog SDK to an app which doesn't depend on the navigation architecture component.
implementation 'com.datadoghq:dd-sdk-android:1.5.2'
Describe what you expected:
I expected fewer transitive dependencies to be brought in, so that the app size wouldn't increase as much.
These dependencies were brought in, even though they don't appear to be used by the Datadog SDK:
androidx.navigation:navigation-ui-ktxandroidx.navigation:navigation-ui
Additional context
- Datadog SDK version: 1.5.2
R8 is being run on the app, so the increase in size in this case was more from the resources being brought in from androidx.navigation:navigation-ui.
Looking at the code in this repo, it seems like the navigation dependencies are being brought in from 1 and 2.
I'm guessing that AndroidXNavigation includes the navigation-ui-ktx since it might be used in the sample app, but it doesn't seem to be needed by the SDK that gets released.
On the other hand, removing this transitive dependency could be considered a breaking change if people were relying on the Datadog SDK to bring it in. But I hope that this isn't the case.
Describe what happened
After adding the Datadog SDK (
com.datadoghq:dd-sdk-android) to my app, I noticed that the app size increased by more than I expected.Steps to reproduce the issue:
Add the Datadog SDK to an app which doesn't depend on the navigation architecture component.
implementation 'com.datadoghq:dd-sdk-android:1.5.2'Describe what you expected:
I expected fewer transitive dependencies to be brought in, so that the app size wouldn't increase as much.
These dependencies were brought in, even though they don't appear to be used by the Datadog SDK:
androidx.navigation:navigation-ui-ktxandroidx.navigation:navigation-uiAdditional context
R8 is being run on the app, so the increase in size in this case was more from the resources being brought in from
androidx.navigation:navigation-ui.Looking at the code in this repo, it seems like the navigation dependencies are being brought in from 1 and 2.
I'm guessing that
AndroidXNavigationincludes thenavigation-ui-ktxsince it might be used in the sample app, but it doesn't seem to be needed by the SDK that gets released.On the other hand, removing this transitive dependency could be considered a breaking change if people were relying on the Datadog SDK to bring it in. But I hope that this isn't the case.