[core] hard-deprecate start/stop/restart/status commands#3004
Conversation
ccd651d to
984aab6
Compare
All of these are handled by Supervisord, which launches the processes in the foreground. This is a complete legacy code, and some people still use it wrongly. This commits still allows these options, but only in developer mode, removing the risk for most people to misuse them. It also removes the deprecation notice for the old command line executables: they are not shipped anymore, and the main reason why they were deprecated was the start/stop/restart/status commands. Since this commit takes care of that, the notices are not needed anymore.
degemer
changed the title
984aab6 to
7580eba
Compare
degemer
changed the title
* master: (254 commits) Reduce the maximum amount of argument to pylint. [forwarder] stop flushing after 10s [etcd] Report errors connecting to etcd endpoint (#3007) Postfix check should pass raise_on_empty_output=False [status] Silence requests exception [psutil] Only set `psutil.PROCFS_PATH` once in the collector (#3013) [ci] fix check name detection of test files (#3021) [ci][rabbitmq] Increase wait timeout (#3022) [core] SpooledTemporaryFile for subprocess output (#3002) [collector] isolate system checks (#3001) [ci] Fix Travis jobs timing out (#3017) [mongo] Use db.current_op instead of manually querying (#3016) [ci] fix bad citizens detection (#3020) [ci] add debug logs (#3019) [mongo] use `currentOp` for mongodb 3.2+ Use proxy for API key check in info page (#3012) [mongo] Add MongoDB 3.2 support [mongo] Add MongoDB 3.2 to travis-ci config [packaging] 5.11.0 nightlies (#3009) [core] hard-deprecate start/stop/restart/status (#3004) ...
|
@degemer How are people meant to use non-supervisord approaches, where all we want is the dogstatsd listener and relay? (see linked issue above). This has basically broken the Heroku Buildpack approach. |
|
@miketheman Sorry to hear that. 😞 I don't know Heroku, would it be possible to do the same as the dogstatsd-only docker image and run supervisor with a custom configuration (starting only dogstatsd & the forwarder)? https://github.com/DataDog/docker-dd-agent/blob/master/dogstatsd/Dockerfile & https://github.com/DataDog/docker-dd-agent/blob/master/dogstatsd/supervisor.conf |
|
@jyee could you help take a look at this as well? |
|
I'd point out that removing a working interface in a non-6.x version seems really wrong, SemVer-wise. |
5 participants
What does this PR do?
This commits still allows these options, but only in developer mode,
removing the risk for most people to misuse them.
It also removes the deprecation notice for the old command line
executables: they are not shipped anymore, and the main reason why they
were deprecated was the start/stop/restart/status commands. Since this
commit takes care of that, the notices are not needed anymore.
Motivation
All of these are handled by Supervisord, which launches the processes in
the foreground. This is a complete legacy code, and some people still
use it wrongly.