Added metrics from Linux /proc stats as sockstat and others#1904
Added metrics from Linux /proc stats as sockstat and others#1904maatthc wants to merge 5 commits into
Conversation
- /proc/net/sockstat - /proc/sys/net/ipv4/tcp_mem - /proc/sys/net/ipv4/tcp_max_orphans - /proc/sys/net/ipv4/netfilter/ip_conntrack_count - /proc/sys/net/ipv4/ip_conntrack_max Also from the command : /usr/bin/getconf PAGESIZE Those are critical metrics for high performance applications.
|
Thanks a lot @maatthc We'll review this PR for our 5.6.0 release. |
There was a problem hiding this comment.
@maatthc This line seems to be causing tests to fail. Would you mind confirming when you have a moment?
ImportError: cannot import name check_output
There was a problem hiding this comment.
Hi,
check_output is only available with Python 2.7 - It will work well with the embedded version that comes with Datadog:
sudo -u dd-agent dd-agent check network
Cheers
|
@maatthc Thank you for your work on this and for being a part of the Datadog community. We'd like to include in this in an upcoming release, but at the moment it looks to be failing tests. Would you mind taking a look at getting them passing? Happy to help if you need any assistance. Most of the failures look to be simple style issues raised by flake8. You can validate these by running flake8 locally. However there also seems to be an issue with the new imports added on line 7. flake8 |
…rotocol - this way you don't need a WebServer running in front of the PHP_FPM process.
|
Added support to Talk to the PHP process using FCGI instead of HTTP protocol - this way you don't need a WebServer running in front of the PHP_FPM process. |
|
Thanks a lot @maatthc Also can you please make sure to comply with the contributing guidelines please ? Thanks again for this work! |
|
Hi guys, Cheers |
3 participants
Also from the command :
/usr/bin/getconf PAGESIZE
Those are critical metrics for high performance applications.