[branch-48] Fix array_agg memory overaccounting#31
Merged
Conversation
* Fix array_agg memory over accounting * Add comment (cherry picked from commit 8a2d618)
gabotechs
changed the title
ahmed-mez
approved these changes
Jun 12, 2025
ahmed-mez
reviewed
Jun 12, 2025
ahmed-mez
left a comment
ahmed-mez
left a comment
There was a problem hiding this comment.
ICYMI a related test case seems to be failing
gabotechs
commented
Jun 12, 2025
| ])])?; | ||
|
|
||
| // without compaction, the size is 17112 | ||
| assert_eq!(acc.size(), 2080); |
Author
There was a problem hiding this comment.
in apache/main, this value is 2112. I have no idea why we need 2080 here for the test to pass.
I don't think investing time in investigating this is worth it, so I'm just going to go ahead and merge this, but I'll keep this in mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks apache#16346