Skip to content

Commit 9504942

Browse files
authored
feat: support col reference for percentiles (apache#25337)
## Which issue does this PR close? - Closes apache#24337. ## Rationale for this change When using a projection as the percentile argument to `approx_percentile_cont` or `percentile_cont`, planning fails because only literals are supported. It makes sense to accept projections that are constant across all batches but not labelled as literals (although they practically are). For example, this query cannot be planned, even though the percentile is constant: ``` SELECT approx_percentile_cont(y, m) AS median FROM ( SELECT t.x + 1 as y, 0.5 as m FROM ( VALUES (10) ) AS t(x) ) ``` ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR. --> Introduce `PercentileParam` and `PercentileParamState` to handle column references or projections for the percentile argument. Resolution of `percentile` cannot always be done: for example, on an empty record batch, we won't be able to get the value from the columns. `PercentileParamState` makes sure the percentile resolution is both flexible enough to wait to be able to resolve the parameter AND applies the strict constraints that are required (constant `Float32` or `Float64`). The percentile is also included in state fields so that the merge_batch in the final Accumulator can process without any issues. ## What is the testing strategy for this PR? This new feature is covered by the `sqllogictest` cases added in `aggregate.slt`. Unit tests have also been added to `approx_percentile_cont.rs` and `percentile_cont.rs`. ## Are there any user-facing changes? No breaking changes. ## Benchark: ClickBench | Query | main | annarose_approx_percentile | Change | | ---------- | ---------- | ---------- | ---------- | | QQuery 0 | 0.73 ms | 0.79 ms | 1.08x slower | | QQuery 1 | 8.10 ms | 8.91 ms | 1.10x slower | | QQuery 2 | 27.90 ms | 30.59 ms | 1.10x slower | | QQuery 3 | 23.27 ms | 23.89 ms | no change | | QQuery 4 | 157.25 ms | 157.70 ms | no change | | QQuery 5 | 197.65 ms | 201.26 ms | no change | | QQuery 6 | 0.72 ms | 0.67 ms | +1.08x faster | | QQuery 7 | 8.20 ms | 8.28 ms | no change | | QQuery 8 | 230.84 ms | 215.32 ms | +1.07x faster | | QQuery 9 | 296.27 ms | 312.37 ms | 1.05x slower | | QQuery 10 | 49.12 ms | 47.66 ms | no change | | QQuery 11 | 58.86 ms | 55.26 ms | +1.07x faster | | QQuery 12 | 198.45 ms | 192.95 ms | no change | | QQuery 13 | 285.28 ms | 280.02 ms | no change | | QQuery 14 | 195.67 ms | 204.80 ms | no change | | QQuery 15 | 184.29 ms | 180.74 ms | no change | | QQuery 16 | 434.20 ms | 457.81 ms | 1.05x slower | | QQuery 17 | 476.52 ms | 427.84 ms | +1.11x faster | | QQuery 18 | 912.71 ms | 881.69 ms | no change | | QQuery 19 | 18.14 ms | 19.41 ms | 1.07x slower | | QQuery 20 | 456.87 ms | 463.23 ms | no change | | QQuery 21 | 468.67 ms | 482.15 ms | no change | | QQuery 22 | 892.28 ms | 896.13 ms | no change | | QQuery 23 | 2520.93 ms | 2558.49 ms | no change | | QQuery 24 | 34.14 ms | 33.50 ms | no change | | QQuery 25 | 99.14 ms | 99.83 ms | no change | | QQuery 26 | 35.25 ms | 34.51 ms | no change | | QQuery 27 | 467.74 ms | 484.36 ms | no change | | QQuery 28 | 1931.71 ms | 1945.50 ms | no change | | QQuery 29 | 29.16 ms | 30.35 ms | no change | | QQuery 30 | 214.69 ms | 209.17 ms | no change | | QQuery 31 | 196.43 ms | 199.65 ms | no change | | QQuery 32 | 583.78 ms | 614.36 ms | 1.05x slower | | QQuery 33 | 1078.73 ms | 1145.79 ms | 1.06x slower | | QQuery 34 | 1073.15 ms | 1117.56 ms | no change | | QQuery 35 | 182.87 ms | 171.52 ms | +1.07x faster | | QQuery 36 | 46.27 ms | 47.18 ms | no change | | QQuery 37 | 24.27 ms | 24.03 ms | no change | | QQuery 38 | 29.58 ms | 29.76 ms | no change | | QQuery 39 | 85.29 ms | 86.14 ms | no change | | QQuery 40 | 8.23 ms | 8.41 ms | no change | | QQuery 41 | 8.12 ms | 8.47 ms | no change | | QQuery 42 | 6.72 ms | 6.81 ms | no change | | Benchmark Summary | | | ---- | ---- | | Total Time (main) | 14238.19ms | | Total Time (annarose_approx_percentile) | 14404.87ms | | Average Time (main) | 331.12ms | | Average Time (annarose_approx_percentile) | 335.00ms | | Queries Faster | 5 | | Queries Slower | 8 | | Queries with No Change | 30 | | Queries with Failure | 0 | ## Memory profiling for clickbench_partitioned ### this branch |Query | Time (ms) | Peak RSS | Peak Commit | Major Page Faults| |--------|----------------|-------------|--------------|-------------| |0|5.43|84.0 MB|171.8 MB|0| |1|11.45|119.6 MB|313.9 MB|0| |2|27.44|240.8 MB|1536.1 MB|0| |3|30.52|412.3 MB|1227.9 MB|0| |4|173.88|2.8 GB|3.2 GB|0| |5|193.60|2.5 GB|2.9 GB|0| |6|3.36|93.0 MB|167.9 MB|0| |7|10.66|128.1 MB|318.8 MB|0| |8|219.80|3.4 GB|4.1 GB|0| |9|268.65|2.4 GB|3.2 GB|0| |10|45.84|780.3 MB|1809.8 MB|0| |11|52.68|788.7 MB|1800.9 MB|0| |12|183.80|2.5 GB|2.9 GB|0| |13|266.55|3.0 GB|3.5 GB|0| |14|191.93|2.4 GB|3.2 GB|0| |15|185.03|3.0 GB|3.3 GB|0| |16|422.42|6.4 GB|7.1 GB|0| |17|404.75|6.1 GB|6.9 GB|0| |18|861.29|12.2 GB|13.1 GB|0| |19|19.20|362.3 MB|1118.0 MB|24| |20|442.22|1171.1 MB|1429.2 MB|0| |21|407.55|1836.8 MB|2.1 GB|0| |22|763.73|2.5 GB|2.8 GB|0| |23|2313.37|4.8 GB|5.5 GB|0| |24|33.92|569.7 MB|959.2 MB|5| |25|82.99|798.0 MB|1517.9 MB|0| |26|35.10|599.1 MB|986.8 MB|0| |27|392.34|1234.9 MB|1455.8 MB|0| |28|1714.18|2.5 GB|2.7 GB|0| |29|28.43|229.9 MB|1497.1 MB|0| |30|191.47|2.2 GB|3.3 GB|0| |31|182.56|2.8 GB|3.7 GB|0| |32|1263.74|13.3 GB|16.2 GB|0| |33|958.16|10.7 GB|10.9 GB|5| |34|956.65|10.6 GB|10.9 GB|0| |35|171.08|2.1 GB|2.6 GB|0| |36|47.33|452.0 MB|800.8 MB|0| |37|26.89|229.4 MB|544.9 MB|0| |38|33.62|270.9 MB|503.8 MB|0| |39|90.83|756.9 MB|1062.6 MB|0| |40|11.41|208.3 MB|433.3 MB|0| |41|11.47|170.3 MB|393.8 MB|0| |42|10.48|142.8 MB|265.1 MB|0| ### main |Query | Time (ms) | Peak RSS | Peak Commit |Major Page Faults| |----------|--------------|------------|----------------|------------| |0|4.76|94.7 MB|171.5 MB|0| |1|11.22|120.7 MB|296.7 MB|0| |2|32.05|244.2 MB|1533.8 MB|0| |3|24.33|417.7 MB|1229.2 MB|0| |4|175.85|2.8 GB|3.2 GB|0| |5|207.07|2.5 GB|3.0 GB|0| |6|3.46|94.3 MB|171.6 MB|0| |7|11.08|129.4 MB|323.5 MB|0| |8|223.08|3.4 GB|4.1 GB|0| |9|288.63|2.4 GB|3.4 GB|0| |10|48.79|792.1 MB|1767.0 MB|0| |11|53.32|760.8 MB|1779.6 MB|0| |12|189.17|2.6 GB|3.1 GB|0| |13|274.96|3.0 GB|3.7 GB|0| |14|202.74|2.6 GB|3.3 GB|0| |15|208.83|3.0 GB|3.4 GB|0| |16|576.37|6.3 GB|7.1 GB|0| |17|623.87|6.5 GB|7.3 GB|0| |18|1140.54|11.3 GB|13.1 GB|0| |19|21.20|370.8 MB|1124.9 MB|26| |20|507.91|1149.3 MB|1364.8 MB|0| |21|479.85|1824.8 MB|2.1 GB|0| |22|914.26|2.3 GB|2.7 GB|0| |23|2757.47|4.6 GB|5.3 GB|0| |24|41.85|591.0 MB|999.1 MB|0| |25|91.00|763.3 MB|1500.8 MB|0| |26|38.90|560.1 MB|980.6 MB|0| |27|506.23|1319.5 MB|1550.4 MB|0| |28|2119.47|2.6 GB|2.7 GB|0| |29|34.79|213.7 MB|1267.2 MB|0| |30|218.63|2.1 GB|3.1 GB|0| |31|212.42|2.8 GB|3.7 GB|0| |32|821.63|13.0 GB|16.1 GB|0| |33|1162.42|10.5 GB|10.7 GB|14| |34|1212.91|10.4 GB|10.6 GB|0| |35|184.71|2.0 GB|2.5 GB|0| |36|58.35|469.5 MB|845.9 MB|0| |37|30.78|240.2 MB|545.1 MB|0| |38|35.43|287.3 MB|485.4 MB|0| |39|92.89|730.8 MB|1074.5 MB|0| |40|11.87|204.7 MB|420.5 MB|0| |41|11.43|171.2 MB|401.5 MB|0| |42|10.57|146.6 MB|275.6 MB|0|
1 parent 99193cb commit 9504942

9 files changed

Lines changed: 808 additions & 109 deletions

File tree

‎datafusion/functions-aggregate/benches/percentile_cont.rs‎

Lines changed: 24 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ use criterion::{BatchSize, Criterion, criterion_group, criterion_main};
2424
use datafusion_expr::function::AccumulatorArgs;
2525
use datafusion_expr::groups_accumulator::GroupsAccumulator;
2626
use datafusion_expr::{Accumulator, AggregateUDFImpl};
27-
use datafusion_functions_aggregate::approx_percentile_cont::ApproxPercentileAccumulator;
27+
use datafusion_functions_aggregate::approx_percentile_cont::ApproxPercentileCont;
2828
use datafusion_functions_aggregate::percentile_cont::PercentileCont;
2929
use datafusion_functions_aggregate_common::aggregate::groups_accumulator::GroupsAccumulatorAdapter;
3030
use datafusion_physical_expr::expressions::{col, lit};
@@ -54,6 +54,28 @@ fn prepare_accumulator() -> Box<dyn Accumulator> {
5454
PercentileCont::new().accumulator(accumulator_args).unwrap()
5555
}
5656

57+
fn prepare_approx_accumulator() -> Box<dyn Accumulator> {
58+
let schema = Arc::new(Schema::new(vec![Field::new("f", DataType::Float64, true)]));
59+
let value_expr = col("f", &schema).unwrap();
60+
let percentile_expr = lit(0.5_f64);
61+
let value_field = value_expr.return_field(&schema).unwrap();
62+
let percentile_field = percentile_expr.return_field(&schema).unwrap();
63+
let accumulator_args = AccumulatorArgs {
64+
return_field: Field::new("f", DataType::Float64, true).into(),
65+
schema: &schema,
66+
expr_fields: &[value_field, percentile_field],
67+
ignore_nulls: false,
68+
order_bys: &[],
69+
is_reversed: false,
70+
name: "approx_percentile_cont(f, 0.5)",
71+
is_distinct: false,
72+
exprs: &[value_expr, percentile_expr],
73+
};
74+
ApproxPercentileCont::new()
75+
.accumulator(accumulator_args)
76+
.unwrap()
77+
}
78+
5779
fn stream_array(len: usize, null_stride: Option<usize>) -> ArrayRef {
5880
let values = (0..len)
5981
.map(|idx| {
@@ -111,14 +133,7 @@ fn grouped_adapter_benchmark(c: &mut Criterion) {
111133
"approx_percentile_cont/groups_accumulator_adapter/8192_groups",
112134
|b| {
113135
b.iter_batched(
114-
|| {
115-
GroupsAccumulatorAdapter::new(|| {
116-
Ok(Box::new(ApproxPercentileAccumulator::new(
117-
0.5,
118-
DataType::Float64,
119-
)) as Box<dyn Accumulator>)
120-
})
121-
},
136+
|| GroupsAccumulatorAdapter::new(|| Ok(prepare_approx_accumulator())),
122137
|mut accumulator| {
123138
accumulator
124139
.update_batch(

‎datafusion/functions-aggregate/src/approx_median.rs‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ use datafusion_expr::{
3434
use datafusion_macros::user_doc;
3535

3636
use crate::approx_percentile_cont::ApproxPercentileAccumulator;
37+
use crate::utils::{PercentileParam, PercentileParamState};
3738

3839
make_udaf_expr_and_func!(
3940
ApproxMedian,
@@ -108,6 +109,7 @@ impl AggregateUDFImpl for ApproxMedian {
108109
Field::new_list_field(Float64, true),
109110
false,
110111
),
112+
Field::new(format_state_name(args.name, "percentile"), Float64, true),
111113
]
112114
.into_iter()
113115
.map(Arc::new)
@@ -138,7 +140,11 @@ impl AggregateUDFImpl for ApproxMedian {
138140
Ok(Box::new(NoopAccumulator::default()))
139141
} else {
140142
Ok(Box::new(ApproxPercentileAccumulator::new(
141-
0.5_f64,
143+
PercentileParam {
144+
aggregate_fn_name: "APPROX_MEDIAN".to_string(),
145+
state: PercentileParamState::Resolved(0.5_f64),
146+
is_desc: false,
147+
},
142148
acc_args.expr_fields[0].data_type().clone(),
143149
)))
144150
}

‎datafusion/functions-aggregate/src/approx_percentile_cont.rs‎

Lines changed: 61 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ use arrow::{
2828
};
2929
use datafusion_common::types::{NativeType, logical_float64};
3030
use datafusion_common::{
31-
DataFusionError, Result, ScalarValue, downcast_value, internal_err, not_impl_err,
31+
Result, ScalarValue, downcast_value, internal_err, not_impl_err, plan_datafusion_err,
3232
plan_err,
3333
};
3434
use datafusion_expr::DistinctHandling;
@@ -43,10 +43,13 @@ use datafusion_functions_aggregate_common::tdigest::{DEFAULT_MAX_SIZE, TDigest};
4343
use datafusion_macros::user_doc;
4444
use datafusion_physical_expr_common::physical_expr::PhysicalExpr;
4545

46-
use crate::utils::{get_scalar_value, validate_percentile_expr};
46+
use crate::utils::{PercentileParam, get_scalar_value};
4747

4848
create_func!(ApproxPercentileCont, approx_percentile_cont_udaf);
4949

50+
// state field index for the percentile argument
51+
pub const STATE_PERCENTILE_IDX: usize = 6;
52+
5053
/// Computes the approximate percentile continuous of a set of numbers
5154
pub fn approx_percentile_cont(
5255
order_by: Sort,
@@ -172,20 +175,17 @@ impl ApproxPercentileCont {
172175
&self,
173176
args: &AccumulatorArgs,
174177
) -> Result<ApproxPercentileAccumulator> {
175-
let percentile =
176-
validate_percentile_expr(&args.exprs[1], "APPROX_PERCENTILE_CONT")?;
177-
178178
let is_descending = args
179179
.order_bys
180180
.first()
181181
.map(|sort_expr| sort_expr.options.descending)
182182
.unwrap_or(false);
183183

184-
let percentile = if is_descending {
185-
1.0 - percentile
186-
} else {
187-
percentile
188-
};
184+
let percentile = PercentileParam::try_new(
185+
&args.exprs[1],
186+
"APPROX_PERCENTILE_CONT",
187+
is_descending,
188+
)?;
189189

190190
let tdigest_max_size = if args.exprs.len() == 3 {
191191
Some(validate_input_max_size_expr(&args.exprs[2])?)
@@ -219,9 +219,8 @@ impl ApproxPercentileCont {
219219

220220
fn validate_input_max_size_expr(expr: &Arc<dyn PhysicalExpr>) -> Result<usize> {
221221
let scalar_value = get_scalar_value(expr).map_err(|_e| {
222-
DataFusionError::Plan(
222+
plan_datafusion_err!(
223223
"Tdigest max_size value for 'APPROX_PERCENTILE_CONT' must be a literal"
224-
.to_string(),
225224
)
226225
})?;
227226

@@ -280,6 +279,11 @@ impl AggregateUDFImpl for ApproxPercentileCont {
280279
Field::new_list_field(DataType::Float64, true),
281280
false,
282281
),
282+
Field::new(
283+
format_state_name(args.name, "percentile"),
284+
DataType::Float64,
285+
true,
286+
),
283287
]
284288
.into_iter()
285289
.map(Arc::new)
@@ -337,21 +341,21 @@ impl AggregateUDFImpl for ApproxPercentileCont {
337341
#[derive(Debug)]
338342
pub struct ApproxPercentileAccumulator {
339343
digest: TDigest,
340-
percentile: f64,
344+
percentile: PercentileParam,
341345
return_type: DataType,
342346
}
343347

344348
impl ApproxPercentileAccumulator {
345-
pub fn new(percentile: f64, return_type: DataType) -> Self {
349+
pub fn new(percentile: PercentileParam, return_type: DataType) -> Self {
346350
Self {
347351
digest: TDigest::new(DEFAULT_MAX_SIZE),
348352
percentile,
349353
return_type,
350354
}
351355
}
352356

353-
pub fn new_with_max_size(
354-
percentile: f64,
357+
pub(crate) fn new_with_max_size(
358+
percentile: PercentileParam,
355359
return_type: DataType,
356360
max_size: usize,
357361
) -> Self {
@@ -362,6 +366,15 @@ impl ApproxPercentileAccumulator {
362366
}
363367
}
364368

369+
/// Callers must only invoke this when a percentile argument actually
370+
/// exists in the current batch.
371+
pub(crate) fn resolve_percentile(
372+
&mut self,
373+
percentile_array: &ArrayRef,
374+
) -> Result<()> {
375+
self.percentile.resolve(percentile_array)
376+
}
377+
365378
// pub(crate) for approx_percentile_cont_with_weight
366379
pub(crate) fn max_size(&self) -> usize {
367380
self.digest.max_size()
@@ -405,10 +418,17 @@ impl ApproxPercentileAccumulator {
405418

406419
impl Accumulator for ApproxPercentileAccumulator {
407420
fn state(&mut self) -> Result<Vec<ScalarValue>> {
408-
Ok(self.digest.to_scalar_state().into_iter().collect())
421+
let mut state: Vec<ScalarValue> =
422+
self.digest.to_scalar_state().into_iter().collect();
423+
state.push(ScalarValue::Float64(self.percentile.get().ok()));
424+
Ok(state)
409425
}
410426

411427
fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
428+
if values.len() > 1 {
429+
self.resolve_percentile(&values[1])?;
430+
}
431+
412432
// Remove any nulls before computing the percentile
413433
let mut values = Arc::clone(&values[0]);
414434
if values.null_count() > 0 {
@@ -424,7 +444,9 @@ impl Accumulator for ApproxPercentileAccumulator {
424444
if self.digest.count() == 0.0 {
425445
return ScalarValue::try_from(self.return_type.clone());
426446
}
427-
let q = self.digest.estimate_quantile(self.percentile);
447+
let q = self
448+
.digest
449+
.estimate_quantile(self.percentile.effective_percentile()?);
428450

429451
// These acceptable return types MUST match the validation in
430452
// ApproxPercentile::create_accumulator.
@@ -441,9 +463,14 @@ impl Accumulator for ApproxPercentileAccumulator {
441463
return Ok(());
442464
}
443465

444-
let states = (0..states[0].len())
466+
if let Some(percentile_array) = states.get(STATE_PERCENTILE_IDX) {
467+
self.percentile.resolve(percentile_array)?;
468+
}
469+
470+
let tdigest_states = &states[..STATE_PERCENTILE_IDX];
471+
let states = (0..tdigest_states[0].len())
445472
.map(|index| {
446-
states
473+
tdigest_states
447474
.iter()
448475
.map(|array| ScalarValue::try_from_array(array, index))
449476
.collect::<Result<Vec<_>>>()
@@ -470,6 +497,19 @@ mod tests {
470497
use datafusion_functions_aggregate_common::tdigest::TDigest;
471498

472499
use crate::approx_percentile_cont::ApproxPercentileAccumulator;
500+
use crate::utils::{PercentileParam, PercentileParamState};
501+
502+
fn make_accumulator() -> ApproxPercentileAccumulator {
503+
ApproxPercentileAccumulator::new_with_max_size(
504+
PercentileParam {
505+
aggregate_fn_name: "APPROX_PERCENTILE_CONT".to_string(),
506+
state: PercentileParamState::Resolved(0.5),
507+
is_desc: false,
508+
},
509+
DataType::Float64,
510+
100,
511+
)
512+
}
473513

474514
#[test]
475515
fn test_combine_approx_percentile_accumulator() {
@@ -486,8 +526,7 @@ mod tests {
486526
let t1 = TDigest::merge_digests(&digests);
487527
let t2 = TDigest::merge_digests(&digests);
488528

489-
let mut accumulator =
490-
ApproxPercentileAccumulator::new_with_max_size(0.5, DataType::Float64, 100);
529+
let mut accumulator = make_accumulator();
491530

492531
accumulator.merge_digests(&[t1]);
493532
assert_eq!(accumulator.digest.count(), 50_000.0);

‎datafusion/functions-aggregate/src/approx_percentile_cont_with_weight.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,9 @@ impl Accumulator for ApproxPercentileWithWeightAccumulator {
308308
}
309309

310310
fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
311+
self.approx_percentile_cont_accumulator
312+
.resolve_percentile(&values[2])?;
313+
311314
let mut means = Arc::clone(&values[0]);
312315
let mut weights = Arc::clone(&values[1]);
313316
// If nulls are present in either array, need to filter those rows out in both arrays

‎datafusion/functions-aggregate/src/median.rs‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ use arrow::datatypes::FieldRef;
2424
use crate::percentile_cont::{
2525
PercentileCont, create_percentile_accumulator, create_percentile_groups_accumulator,
2626
};
27+
use crate::utils::{PercentileParam, PercentileParamState};
2728
use datafusion_common::Result;
2829
use datafusion_common::types::logical_float64;
2930
use datafusion_expr::GroupsAccumulator;
@@ -123,7 +124,11 @@ impl AggregateUDFImpl for Median {
123124
fn accumulator(&self, args: AccumulatorArgs) -> Result<Box<dyn Accumulator>> {
124125
create_percentile_accumulator(
125126
self.name(),
126-
0.5,
127+
PercentileParam {
128+
aggregate_fn_name: "MEDIAN".to_string(),
129+
state: PercentileParamState::Resolved(0.5),
130+
is_desc: false,
131+
},
127132
args.expr_fields[0].data_type(),
128133
args.is_distinct,
129134
)
@@ -139,7 +144,11 @@ impl AggregateUDFImpl for Median {
139144
) -> Result<Box<dyn GroupsAccumulator>> {
140145
create_percentile_groups_accumulator(
141146
self.name(),
142-
0.5,
147+
PercentileParam {
148+
aggregate_fn_name: "MEDIAN".to_string(),
149+
state: PercentileParamState::Resolved(0.5),
150+
is_desc: false,
151+
},
143152
args.expr_fields[0].data_type(),
144153
)
145154
}

0 commit comments

Comments
 (0)