You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 34149d9
Browse filesBrowse the repository at this point in the historyBrowse files
Gustavo Schneiter
authored and
Gene Bordegaray
committed
feat: support co-partitioned range right-side equi hash joins (apache#23484)
## Which issue does this PR close?
- Closesapache#23453.
- Part of apache#22395.
## Rationale for this change
apache#23184 let compatible range-partitioned inputs satisfy **inner**
partitioned hash joins without repartitioning. Right-side partitioned
equi joins have the same locality guarantee: `Right`, `RightSemi`,
`RightAnti` and `RightMark` all anchor every output row on the probe
(right) partition (`on_lr_is_preserved` is probe-side for all four), so
when both inputs are co-partitioned by the join keys, execution stays
partition-local and the hash repartition is unnecessary.
This removes unnecessary `RepartitionExec`s for already-co-located
inputs, extending the inner-join behavior from apache#23184 to the right-side
variants. No micro-benchmark included, consistent with apache#23184;
correctness is demonstrated by matched/unmatched execution results
below.
## What changes are included in this PR?
The only production change is widening the existing inner-only gate in
`HashJoinExec::input_distribution_requirements` from `join_type ==
JoinType::Inner` to `matches!(join_type, Inner | Right | RightSemi |
RightAnti | RightMark)` (under `PartitionMode::Partitioned`). The
`co_partitioned` / range-satisfaction machinery from apache#23184 is unchanged
— the sanity checker and enforce_distribution consume range satisfaction
join-type-agnostically.
One behavior note for apache#23376: range co-partitioned right joins now stay
`Range`/`Range`, so partitioned dynamic filters are disabled for them
(`has_partitioned_dynamic_filter_routing` returns false), the same safe
delta apache#23184 introduced for inner joins. These variants are
probe-not-preserved for pruning, so dynamic filters were not eligible to
prune their probe rows regardless.
## Are these changes tested?
Yes.
- Optimizer (`enforce_distribution.rs`): 4 reuse tests (one per join
type) proving compatible range/range inputs keep `Range` partitioning
with no `RepartitionExec`; 4 incompatibility tests proving that
mismatched split points, sort options, partition counts, or join-key
expressions still insert a hash repartition; sanity-check pairs
mirroring apache#23184.
- Execution (`range_partitioning.slt`): `EXPLAIN` plan pins plus
matched/unmatched result checks for `Right` (incl. `NULL` left values),
`RightSemi`, `RightAnti`, and an incompatible-layout `Right` join
(repartitions, correct results).
- The new reuse tests fail on `main` without the gate change (verified
by reverting the production diff: exactly the 4 reuse tests fail,
everything else passes).
- `RightMark` testing note: `RightMark` is not reachable from SQL in
sqllogictest (`IN`-subquery decorrelation emits `LeftMark`; physical
`RightMark` only appears via a statistics-based swap), so its
co-partitioning behavior is pinned at the optimizer/plan level, and mark
null-marker semantics (matched/unmatched/`NULL` build keys) are pinned
via the `LeftMark` path in the slt.
## Are there any user-facing changes?
No API changes. Plans over compatible range-partitioned inputs avoid a
hash repartition for right-side equi hash joins.
0 commit comments