This repository was archived by the owner on Aug 30, 2019. It is now read-only.
internal/agent: slightly improve Normalize output#553
Merged
Conversation
LotharSee
approved these changes
Jan 3, 2019
erichgess
reviewed
Jan 3, 2019
| // If the end date is too far away in the future, it's probably a mistake. | ||
| if s.Start+s.Duration > time.Now().Add(MaxEndDateOffset).UnixNano() { | ||
| return fmt.Errorf("span.normalize: more than %v in the future", MaxEndDateOffset) | ||
| return fmt.Errorf("invalid `Start`+`Duration`: too far in the future") |
There was a problem hiding this comment.
Could we include the value of the invalid end date in the message? My experience is that makes debugging much easier, and I think that's the error message pattern you're using elsewhere :)
Contributor
Author
There was a problem hiding this comment.
Sorry, too late now, but will do as a follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly improves error messages, making them more consistent and in some cases more explicit.