This repository was archived by the owner on Aug 30, 2019. It is now read-only.
internal/config: allow setting environment using environment variable#548
Merged
Conversation
Contributor
|
I thought we agreed within #502 that the problem was resolved and this isn't needed. |
gbbr
changed the title
Author
|
Well, there is a workaround with some code changes in the application. But I still think it is good to be able to set it on the agent even in docker environments. You said in that issue
So I thought it would get fixed in the env config loading refactoring, #531 but it seems it wasn't, so therefore created this PR. |
gbbr
approved these changes
Dec 24, 2018
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the explanation. You're right, this wasn't part of those changes. Let's add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #502