Skip to content
This repository was archived by the owner on Aug 30, 2019. It is now read-only.

config: use shared config for env loading#531

Merged
gbbr merged 5 commits into
masterfrom
gbbr/guild-env
Nov 26, 2018
Merged

config: use shared config for env loading#531
gbbr merged 5 commits into
masterfrom
gbbr/guild-env

Conversation

@gbbr

@gbbr gbbr commented Nov 26, 2018

Copy link
Copy Markdown
Contributor
  • Read environment variables into shared config.Datadog
  • Add tests for all environment variable overrides for both .conf and .yaml files
  • Fix flaky tests
  • Name files better
  • Move DynamicConfig into sampler. This configuration is sampler-provided and was confusingly located in the config package.

@gbbr gbbr added this to the 6.8.0 milestone Nov 26, 2018
@gbbr
gbbr requested review from AlexJF and LotharSee November 26, 2018 13:33
@gbbr
gbbr merged commit be953ea into master Nov 26, 2018
@gbbr
gbbr deleted the gbbr/guild-env branch November 26, 2018 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants