This repository was archived by the owner on Aug 30, 2019. It is now read-only.
event: Ensure event priorities are propagated to Datadog backend.#527
Merged
Conversation
gbbr
approved these changes
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace priority is stored as a metric on the root span.
Therefore, events extracted from the root span (the usual case) already include it by default. However, if events are extracted from non-root spans, they would not include the priority metric when sent to the backend so the backend would not know what priority they were associated with.
This PR ensures priorities are set on extracted event spans if the trace from which they were extracted contained a priority.