This repository was archived by the owner on Aug 30, 2019. It is now read-only.
event: allow out-of-the-box APM event extraction.#513
Merged
Conversation
AlexJF
changed the title
This was referenced Nov 2, 2018
AlexJF
force-pushed
the
alexjf/metric-based-event-extractor
branch
from
November 2, 2018 14:46
706cdbc to
4b1d98f
Compare
gbbr
changed the title
gbbr
reviewed
Nov 5, 2018
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
I think the current implementation is great! I'm happy with this outcome. Two comments about iterating over the events again and the unnecessary secondary return value are important to me, the rest are just nits.
LotharSee
reviewed
Nov 5, 2018
LotharSee
reviewed
Nov 5, 2018
LotharSee
reviewed
Nov 5, 2018
gbbr
reviewed
Nov 5, 2018
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
To me this looks good now, minus some minor comments and Benjamin's.
gbbr
reviewed
Nov 5, 2018
LotharSee
reviewed
Nov 5, 2018
gbbr
reviewed
Nov 5, 2018
gbbr
reviewed
Nov 5, 2018
LotharSee
reviewed
Nov 5, 2018
gbbr
reviewed
Nov 6, 2018
gbbr
reviewed
Nov 6, 2018
LotharSee
reviewed
Nov 7, 2018
LotharSee
reviewed
Nov 7, 2018
gbbr
dismissed
their stale review
November 13, 2018 09:40
Stale. Lots of changes happened. Will review again.
AlexJF
force-pushed
the
alexjf/metric-based-event-extractor
branch
from
November 13, 2018 09:56
8ac92b4 to
57be144
Compare
LotharSee
reviewed
Nov 14, 2018
LotharSee
reviewed
Nov 14, 2018
gbbr
reviewed
Nov 15, 2018
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Some of my usual nits but also a suggestion for the "Extract" return values conversation.
gbbr
approved these changes
Nov 15, 2018
gbbr
left a comment
gbbr
left a comment
Contributor
There was a problem hiding this comment.
Thank you Alex ❤️ Let’s have @LotharSee approve too and then we should merge this.
gbbr
approved these changes
Nov 15, 2018
LotharSee
approved these changes
Nov 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to enable out-of-the-box APM event extraction without requiring explicit agent configuration.
To that end, it adds:
events/sec/agent.