writer: simplify monitor#503
Conversation
Ran command:
mv backoff writer/
| } | ||
|
|
||
| func (w *multiSender) Monitor() <-chan interface{} { return w.mch } | ||
| func (w *multiSender) monitor() <-chan monitorEvent { return w.mch } |
There was a problem hiding this comment.
Why make Monitor private? This way, no one outside of this package will be able to use a sender?
| type eventType int | ||
|
|
||
| const ( | ||
| eventTypeSuccess eventType = iota |
There was a problem hiding this comment.
Again, if these are private no one outside of this package will be able to use a sender. If this is indeed your intention we should set the whole PayloadSender and everything directly related to it as private and only leave actual writers public.
There was a problem hiding this comment.
That's the plan, yeah. Nobody's using them outside of writer, so there is no point to export them or make them visible in the public documentation. Most of these packages should be internal anyway.
Would you like me to do that within the scope of this PR?
AlexJF
left a comment
AlexJF
left a comment
There was a problem hiding this comment.
Ok just confirming this was indeed your intention. In that case feel free to do it over several PRs.
|
Thank you Alex. |
2 participants
In this change:
backoffpackage intowriterfolder.