This repository was archived by the owner on Aug 30, 2019. It is now read-only.
Conversation
palazzem
reviewed
Oct 9, 2018
| c.APIEndpoint = apiEndpointPrefix + yc.Site | ||
| } | ||
| if yc.TraceAgent.Endpoint != "" { | ||
| c.APIEndpoint = yc.TraceAgent.Endpoint |
| }) | ||
| } | ||
|
|
||
| func TestSite(t *testing.T) { |
There was a problem hiding this comment.
@olivielpeau can you double check if it respects entirely our specification?
olivielpeau
approved these changes
Oct 9, 2018
olivielpeau
left a comment
olivielpeau
left a comment
Member
There was a problem hiding this comment.
LGTM, just a nit on the log message
| }) | ||
| } | ||
|
|
||
| func TestSite(t *testing.T) { |
4 tasks
Contributor
Author
|
@palazzem PTAL |
palazzem
approved these changes
Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new
sitetop level configuration option, such that:siteis set,https://trace.agent.<site>is used.siteandapm_dd_urlare set, the latter takes precedence and user is notified.apm_dd_urlis set, that value will be used.