Skip to content
This repository was archived by the owner on Aug 30, 2019. It is now read-only.

cmd/trace-agent: factor out receiver into "api" package#480

Merged
gbbr merged 1 commit into
masterfrom
gbbr/receiver-api
Oct 5, 2018
Merged

cmd/trace-agent: factor out receiver into "api" package#480
gbbr merged 1 commit into
masterfrom
gbbr/receiver-api

Conversation

@gbbr

@gbbr gbbr commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

The goal is to separate all the stuff from cmd/trace-agent into smaller packages and ultimately end up with a clear separation between the three main (high level) functionalities of the agent:

  • API (aka receiver)
  • Processing pipeline (sampling, collecting stats, etc. - currently cmd/trace-agent)
  • Writers

Clearer separation will eventually facilitate better testing. There is no change to functionality.

@gbbr gbbr added this to the 6.6.0 milestone Oct 4, 2018
@gbbr
gbbr requested review from LotharSee and vlad-mh October 4, 2018 21:13

@LotharSee LotharSee left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legitimate move, good to me!

@gbbr

gbbr commented Oct 5, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for helping.

@gbbr
gbbr merged commit 82378eb into master Oct 5, 2018
@gbbr
gbbr deleted the gbbr/receiver-api branch October 5, 2018 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants