obfuscate: account for bracketed identifiers as AS parameters by gbbr · Pull Request #474 · DataDog/datadog-trace-agent

gbbr · 2018-09-24T11:02:15Z

First commit: resolves obfuscate: MSSQL-style bracketed parameters to AS result in odd behaviour #475
Second commit: ensures that filters are reset every time a new obfuscator is initialized. Without this change, tests were failing when the filters returned tokenizing errors because the state was shared in a global object.

gbbr added the do-not-merge/WIP label Sep 24, 2018

gbbr force-pushed the gbbr/mssql branch 3 times, most recently from febb9a2 to 537af7b Compare September 24, 2018 11:16

gbbr requested a review from palazzem September 24, 2018 11:34

gbbr added 2 commits September 24, 2018 16:59

obfuscate: account for bracketed identifiers as AS parameters

507a78a

obfuscate: made tokenConsumer resettable and private

7ae59e3

gbbr force-pushed the gbbr/mssql branch from cade5a4 to 7ae59e3 Compare September 24, 2018 13:59

gbbr removed the do-not-merge/WIP label Sep 25, 2018

palazzem approved these changes Sep 26, 2018

View reviewed changes

gbbr added this to the 6.6.0 milestone Sep 26, 2018

gbbr merged commit c200dbb into master Sep 26, 2018

gbbr deleted the gbbr/mssql branch September 26, 2018 14:18

Provide feedback