This repository was archived by the owner on Aug 30, 2019. It is now read-only.
obfuscate: use strings.Builder from go1.10#471
Merged
Merged
Conversation
Contributor
Author
|
rochdev
suggested changes
Sep 17, 2018
rochdev
left a comment
rochdev
left a comment
Member
There was a problem hiding this comment.
The documentation still mentions Go 1.9+ as the minimum version for development.
This change updates JSON and Redis obfuscator to use `strings.Builder` instead of `bytes.Buffer` for a minor speed increase. It also updates CI to use go1.10, where this new structure was added.
Contributor
Author
|
@rochdev 👏 excellent! Done. |
rochdev
approved these changes
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates JSON and Redis obfuscator to use
strings.Builderinstead of
bytes.Bufferfor a minor speed increase. It also updates CIto use go1.10, where this new structure was added.
Additionally, it also fixes a minor bug with an error message in the
configpackage.