config: add "connection_limit" option to yaml config#443
Conversation
This adds the `connection_limit` configuration option to the yaml configuration `apm_config` section to match the `ini` settings.
There was a problem hiding this comment.
While I have nothing against adding this attribute to allow parity with the .ini, this is a deprecated option. We should prefer WatchdogMaxConns.
However its code hasn't been removed.
Let's add least add a comment that it is undocumented/deprecated? Or maybe remove it fully now?
|
Sorry @LotharSee only read the second part of your comment now. Let's see what @palazzem has to say (since he requested this change). Based on that answer I will make a follow-up PR. |
|
One thing to note: "watchdog" kills the agent if the connection limit is exceeded, is this really what we want? The "old" ConnectionLimit simply errors. Seems less brutal. |
|
@gbbr for now let's keep that change because we can deal with that later (in a minor release since we're deprecating a behavior). For the WatchDog question, we may revisit the approach. |
This adds the `connection_limit` configuration option to the yaml configuration `apm_config` section to match the `ini` settings.
3 participants
This adds the
connection_limitconfiguration option to the yamlconfiguration
apm_configsection to match theinisettings.