This repository was archived by the owner on Aug 30, 2019. It is now read-only.
Makefile: add 'binaries' command to help release pre-compiled binaries.#442
Merged
Conversation
tylerbenson
approved these changes
Jun 22, 2018
LotharSee
reviewed
Jun 22, 2018
| go install ./cmd/trace-agent | ||
|
|
||
| binaries: | ||
| test -n "$(V)" # $$V must be set to the release version, e.g. "make binaries V=1.2.3" |
There was a problem hiding this comment.
If that's expected to be the binary version, you should also set TRACE_AGENT_VERSION as that's the version going to be set in the binary itself.
Contributor
Author
There was a problem hiding this comment.
Good catch! Thanks! I've added the go generate command before creating the binaries, based on V.
gbbr
force-pushed
the
gbbr/x-compile
branch
2 times, most recently
from
June 22, 2018 10:06
bdc72e8 to
2e99466
Compare
vlad-mh
approved these changes
Jun 22, 2018
LotharSee
approved these changes
Jun 22, 2018
gbbr
added a commit
that referenced
this pull request
Jul 12, 2018
…s. (#442) * Makefile: add 'binaries' command to help release pre-compiled binaries. * Makefile: checkout and build binaries from V * README: update binary name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows running:
Which would result in checking out and compiling the binaries for revision
6.2.1into the./binfolder. They are namedtrace-agent-{$GOOS}-{$GOARCH}-6.2.1