Skip to content
This repository was archived by the owner on Aug 30, 2019. It is now read-only.

model: improve normalization error logging#439

Merged
gbbr merged 1 commit into
masterfrom
gbbr/logs
Jun 21, 2018
Merged

model: improve normalization error logging#439
gbbr merged 1 commit into
masterfrom
gbbr/logs

Conversation

@gbbr

@gbbr gbbr commented Jun 20, 2018

Copy link
Copy Markdown
Contributor

Previously it was possible to have errors of the form:

dropping trace reason: invalid span service:"demo" name:"say_hello" traceID:15524911522457890473 spanID:15524911522457890473 start:1527862614328407040..

Serving not much relevant information due to truncation. This change removes outputting the entire faulty span and slightly improves the specificity of the output.

@gbbr gbbr added this to the next milestone Jun 20, 2018

@LotharSee LotharSee left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, much better!

@gbbr
gbbr merged commit 956d4c5 into master Jun 21, 2018
@gbbr
gbbr deleted the gbbr/logs branch June 22, 2018 15:45
gbbr added a commit that referenced this pull request Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants