This repository was archived by the owner on Aug 30, 2019. It is now read-only.
quantizer: allow variable assignments in SQL queries#437
Merged
Conversation
gbbr
force-pushed
the
gbbr/quantize-assign
branch
2 times, most recently
from
June 19, 2018 08:16
a905c13 to
109ae21
Compare
gbbr
force-pushed
the
gbbr/quantize-assign
branch
2 times, most recently
from
June 19, 2018 12:00
7fbc1ff to
7d42f46
Compare
LotharSee
approved these changes
Jun 20, 2018
This change alters the tokenizer to allow ":=" assignments in SELECT parameters, treating them as regular assignments. Previously this would cause the parser to return an error and fail to tokenize the query.
gbbr
force-pushed
the
gbbr/quantize-assign
branch
from
June 21, 2018 06:43
87cfa17 to
1587ddf
Compare
kevinlebrun
approved these changes
Jun 21, 2018
gbbr
added a commit
that referenced
this pull request
Jul 12, 2018
* quantizer: allow variable assignments in SQL queries This change alters the tokenizer to allow ":=" assignments in SELECT parameters, treating them as regular assignments. Previously this would cause the parser to return an error and fail to tokenize the query. * quantizer: no space between ":" and "="
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change alters the tokenizer to allow
:=assignments in SELECTparameters, treating them as regular assignments. Previously this would
cause the parser to return an error and fail to tokenize the query.
Now
:=will be seen as a valid assignment.