This repository was archived by the owner on Aug 30, 2019. It is now read-only.
build: make build fail on linting errors.#436
Merged
Merged
Conversation
This makes `golint` use exit status 1 when linting errors are found. It also fixes any already-existing linting errors.
lucaspimentel
approved these changes
Jun 18, 2018
vlad-mh
approved these changes
Jun 19, 2018
LotharSee
approved these changes
Jun 19, 2018
gbbr
added a commit
that referenced
this pull request
Jul 12, 2018
This makes `golint` use exit status 1 when linting errors are found. It also fixes any already-existing linting errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
golintuse exit status 1 when linting errors are found. Italso fixes any already-existing linting errors.